Add PW-RBSC-cor_6th-ed #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a few typos and syntax was wrong for single linked instances
aeidi89
reviewed
Apr 18, 2024
| "@id": "https://openminds.ebrains.eu/instances/commonCoordinateSpaceVersion/PW-RBSC-corT_v2004-Bregma-left", | ||
| "@type": "https://openminds.ebrains.eu/core/CommonCoordinateSpaceVersion", | ||
| "abbreviation": "PW-RBSC-corT", | ||
| "accessibilty": { |
There was a problem hiding this comment.
GitHub Actions flagged this one as a spelling error
There was a problem hiding this comment.
jup...should be "accessibility" (last i is missing...)
aeidi89
reviewed
Apr 18, 2024
| "@id": "https://openminds.ebrains.eu/instances/commonCoordinateSpaceVersion/PW-RBSC-corT_v2004-Bregma-right", | ||
| "@type": "https://openminds.ebrains.eu/core/CommonCoordinateSpaceVersion", | ||
| "abbreviation": "PW-RBSC-corT", | ||
| "accessibilty": { |
There was a problem hiding this comment.
Thanks! I corrected them now 🙂
aeidi89
reviewed
Apr 18, 2024
| "@id": "https://openminds.ebrains.eu/instances/commonCoordinateSpaceVersion/PW-RBSC-corT_v2004-Interaural-left", | ||
| "@type": "https://openminds.ebrains.eu/core/CommonCoordinateSpaceVersion", | ||
| "abbreviation": "PW-RBSC-corT", | ||
| "accessibilty": { |
aeidi89
reviewed
Apr 18, 2024
| "@id": "https://openminds.ebrains.eu/instances/commonCoordinateSpaceVersion/PW-RBSC-corT_v2004-Interaural-right", | ||
| "@type": "https://openminds.ebrains.eu/core/CommonCoordinateSpaceVersion", | ||
| "abbreviation": "PW-RBSC-corT", | ||
| "accessibilty": { |
aeidi89
approved these changes
Apr 18, 2024
apdavison
added a commit
that referenced
this pull request
Apr 19, 2024
|
We found that my script introduced a typo in the type (instead of "sands", the path had "core"). The last commits fixed this. |
Change left and right in the version ID (and therefore also in the at_id and lookup label), to the 3-letter abbreviation for the anatomical axes orientation e.g. v2004 (Bregma, right) changed into v2004 (Bregma, RIA)
lzehl
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After several discussion with both @lzehl and @aeidi89, I manage to populate the content for Paxinos and Watson's 6th edition of their atlas. Since it's actually 3 atlases in one book (one for each anatomical plane) and they did not define a negative axis for the mediolateral axis (positive values in both directions), this is only the PR for the coronal atlas and includes 4 different CCSVs and corrsponding BAVs (2 different origins and left & right oriented because of the poorly defined mediolateral axis).
I also made a repository with an overview, the script and the input files here: https://github.com/UlrikeS91/AtlasIntegration-into-openMINDS/tree/main/PaxinosWatson-RBSC.
As for the PR for Swanson, @aeidi89 could you please review the content one last time and @lzehl could you please review the rest?