Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PEV instances for RBSC PW v6 #264

Closed
wants to merge 4 commits into from
Closed

Added PEV instances for RBSC PW v6 #264

wants to merge 4 commits into from

Conversation

ehennestad
Copy link
Contributor

No description provided.

@aeidi89 aeidi89 self-assigned this Jul 20, 2023
@aeidi89
Copy link
Collaborator

aeidi89 commented Jul 21, 2023

@lzehl
Does the order of the metadata in the schema matter?
E.g. "alternateName" is the 5th metadata in the schema, could it be placed at the end of the schema?

@lzehl
Copy link
Member

lzehl commented Jul 21, 2023

@aeidi89 properties and value lists should be ordered alphabetically

@aeidi89
Copy link
Collaborator

aeidi89 commented Jul 24, 2023

@aeidi89 properties and value lists should be ordered alphabetically

Thank you @lzehl

@ehennestad could you please rearrange the properties and values so they are listed alphabetically?

@matsalan
Copy link

matsalan commented Aug 3, 2023

Hi, i have rearranged the properties and values so they are listed alphabetically, could you give me permission to push the changes?

@aeidi89
Copy link
Collaborator

aeidi89 commented Aug 3, 2023

Hi, i have rearranged the properties and values so they are listed alphabetically, could you give me permission to push the changes?

@lzehl is this possible?

With a program i changed the order of the lines to match an alphabetical order.
@lzehl
Copy link
Member

lzehl commented Aug 10, 2023

@matsalan thank you for correcting the alphabetical order of the properties in the JSONLD files. However now all the JSONLDs are missing the newline character at the end of each file (POSIX standard) and the indent should be corrected to two spaces per tab.

General question: What is RBSC PW v6 ? I would suggest to also register the respective Brain Atlas Version already with at least minimal information.

I changed the new line format from CRLF to LF and indent to 2 per tab.
@matsalan
Copy link

It should be corrected now @lzehl.

@lzehl
Copy link
Member

lzehl commented Aug 10, 2023

@matsalan I'm sorry but the files still miss the newline character at the end. I also still don't know the meaning for "RBSC PW v6" depending on this the lookup labels / atids may need correction as well

@lzehl
Copy link
Member

lzehl commented Aug 10, 2023

@matsalan if you work in Python you have to add the newline character explicitely (for some reason python ignores so far the POSIX standard

@matsalan
Copy link

Is the line suppose to end with \n?

@lzehl
Copy link
Member

lzehl commented Aug 10, 2023

@matsalan yes each json needs to end with \n

@matsalan
Copy link

Ah, but just at the bottom, not every single line right? @lzehl

@lzehl
Copy link
Member

lzehl commented Aug 10, 2023

At the bottom. Here the way to do this via python when saving the json

with open('FILENAME.jsonld', 'a') as outfile:
    for hostDict in ....:
        json.dump(hostDict, outfile)
        outfile.write('\n') #important part rest can be different in your case

@matsalan
Copy link

Okay, was that done correctly? @lzehl

@lzehl
Copy link
Member

lzehl commented Aug 10, 2023

@matsalan yepp 👍 thanks.

Now to the naming convention:
"RBSC PW v6" apparently stands for "Rat Brain Stereotaxic Paxinos Watson version 6" (@aeidi89 thanks 🙂)
I'm wondering though if the full name would not rather be "Paxinos and Watson's The Rat Brain in Stereotaxic Coordinates". And respectively the short name "Paxinos and Watson's Rat Brain" and the abbreviation "PW-RatBrain" or "PW-RBSC" or "PWRBSC".

Unless "RBSC PW" is an official abbreviation already in use by the community.

Depending on this we should further correct the filenames, the "@id" and the "lookupLabel" of the PEVs

@lzehl
Copy link
Member

lzehl commented Aug 10, 2023

@aeidi89 could we create please with this PR as well the instance for the Brain Atlas Version (with minimum metadata informations) already?

@aeidi89
Copy link
Collaborator

aeidi89 commented Aug 21, 2023

@lzehl
Yes, we should create the Brain Atlas Version
I will have a look at doing that this week

@aeidi89 aeidi89 requested a review from UlrikeS91 April 3, 2024 08:42
@UlrikeS91
Copy link
Collaborator

UlrikeS91 commented Apr 16, 2024

I will close the PR for several reasons:

  1. instances have been combined into one repo https://github.com/openMetadataInitiative/openMINDS_instances/ and no more instances are added in the SANDS repo
  2. I found errors in some of the file names of this PR
  3. I want to remove all information about annotations since this is a copyright protected atlas. I don't think we would get in trouble for stating that the annotations have been made on both hemispheres, but I just do not want to mention anything related to annotations to be on the save side.
  4. All other components of the atlas are missing (BA, BAV, CCS, CCSV and PEs).

Therefore, I have started this from scratch and made a PR in the instance repo: openMetadataInitiative/openMINDS_instances#43

@UlrikeS91 UlrikeS91 closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants