-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PEV instances for RBSC PW v6 #264
Added PEV instances for RBSC PW v6 #264
Conversation
@lzehl |
@aeidi89 properties and value lists should be ordered alphabetically |
Thank you @lzehl @ehennestad could you please rearrange the properties and values so they are listed alphabetically? |
Hi, i have rearranged the properties and values so they are listed alphabetically, could you give me permission to push the changes? |
@lzehl is this possible? |
With a program i changed the order of the lines to match an alphabetical order.
@matsalan thank you for correcting the alphabetical order of the properties in the JSONLD files. However now all the JSONLDs are missing the newline character at the end of each file (POSIX standard) and the indent should be corrected to two spaces per tab. General question: What is RBSC PW v6 ? I would suggest to also register the respective Brain Atlas Version already with at least minimal information. |
I changed the new line format from CRLF to LF and indent to 2 per tab.
It should be corrected now @lzehl. |
@matsalan I'm sorry but the files still miss the newline character at the end. I also still don't know the meaning for "RBSC PW v6" depending on this the lookup labels / atids may need correction as well |
@matsalan if you work in Python you have to add the newline character explicitely (for some reason python ignores so far the POSIX standard |
Is the line suppose to end with \n? |
@matsalan yes each json needs to end with \n |
Ah, but just at the bottom, not every single line right? @lzehl |
At the bottom. Here the way to do this via python when saving the json with open('FILENAME.jsonld', 'a') as outfile:
for hostDict in ....:
json.dump(hostDict, outfile)
outfile.write('\n') #important part rest can be different in your case |
Okay, was that done correctly? @lzehl |
@matsalan yepp 👍 thanks. Now to the naming convention: Unless "RBSC PW" is an official abbreviation already in use by the community. Depending on this we should further correct the filenames, the |
@aeidi89 could we create please with this PR as well the instance for the Brain Atlas Version (with minimum metadata informations) already? |
@lzehl |
I will close the PR for several reasons:
Therefore, I have started this from scratch and made a PR in the instance repo: openMetadataInitiative/openMINDS_instances#43 |
No description provided.