Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBERON terms with 'layer' in their name #207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

UlrikeS91
Copy link
Contributor

generation of terms is described in #133 and fully-automated (with minor clean-ups here and there)

Filtering:
any term with 'layer' in name

Note: This is not to definitively group terms but to create smaller PRs with terms that are potentially related. Hopefully, this makes it easier to review but please do not request to remove terms because they do not fit into the grouping. Only consider whether or not they are suitable UBERONParcellations.

@UlrikeS91 UlrikeS91 added the request any request or update for instances that are not covered by Technique, ContentType or SANDS label label Jan 18, 2025
@UlrikeS91 UlrikeS91 requested review from lzehl and spieschnik January 18, 2025 13:08
@UlrikeS91 UlrikeS91 self-assigned this Jan 18, 2025
Copy link
Contributor

@spieschnik spieschnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All files look ok in general.
We should discuss if the 10 files from sublaminarLayersS1OrS2.jsonld until sublaminarLayersS4OrS5.jsonld should be included?
Also, as a general discussion point: how many sensory related terms do we want to include? Many terms in this PR are originating from the retina or the olfactory bulb.

@UlrikeS91
Copy link
Contributor Author

All files look ok in general. We should discuss if the 10 files from sublaminarLayersS1OrS2.jsonld until sublaminarLayersS4OrS5.jsonld should be included?

@spieschnik pointed those out in person to me, especially because each layer exists as it's own term (sublaminarLayerS1.jsonld to sublaminarLayerS5.jsonld).
Their descriptions say "One of sublaminar layers [...].", which I find redundant since each layer also exists as a stand-alone file. I would argue that this subdivision is not necessary. Either a user can state the specific layer or, if that's not possible, the superclass "inner plexiform layer of retina".

Either way, the second discussion point should be handled first. This is related to the retina, if we do not want to capture any retina related terms anyway, we do not have to discuss these terms.

Also, as a general discussion point: how many sensory related terms do we want to include? Many terms in this PR are originating from the retina or the olfactory bulb.

Olfactory bulb is none debatable. Terms related to it must be included. I was a bit confused why the retina was included in the minimal nervous system subset, but Google gave the answer: "Despite its peripheral location, the retina or neural portion of the eye, is actually part of the central nervous system." (source: https://www.ncbi.nlm.nih.gov/books/NBK10885/)

However, the question is still important to answer. Let's start with what should not be included here - any term that fits into one of our other terminologies for 'CellType', 'Organ', 'OrganismSubstance', 'OrganismSystem' and 'SubcellularEntity'. For example, I remember that there were several terms with UBERON IDs describing receptor types, these should then end up in 'SubcellularEntity'.

But do we want to restrict UBERONParcellation further or should this include any term with an UBERON ID that is representing an anatomical parcellation/entity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request any request or update for instances that are not covered by Technique, ContentType or SANDS label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants