Skip to content

Create initial Entities data model specification. #4442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 10, 2025

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Mar 6, 2025

Adds an initial cut at the Entity DataModel specification from OTEP 256.

Changes

  • Adds information to Resource readme.
  • Creates an initial Resource DataModel with content from Entities SIG discussions on purpose and usage or Resource.
  • Creates an entities diretory for storing Entities DataModel.

See open-telemetry/opentelemetry-proto#635 for related protocol change.

Prototypes:

@jsuereth jsuereth marked this pull request as ready for review March 6, 2025 19:11
@jsuereth jsuereth requested review from a team as code owners March 6, 2025 19:11
@jsuereth jsuereth added this to Entities Mar 6, 2025
@jsuereth jsuereth moved this to In Progress in Entities Mar 6, 2025
@jack-berg
Copy link
Member

@jsuereth and other folks from the entities SIG - it would be good to get reviews / approvals from the entities group first to get a signal that this is indeed the agreed direction / consensus of that group.

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. matches what we've been talking about for months. These comments should be considered nits and non-blocking

Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few small comments.

@jsuereth
Copy link
Contributor Author

jsuereth commented Apr 8, 2025

Given we have enough approvals, would like to merge this by end of week, please take a look.

@jsuereth jsuereth requested a review from tigrannajaryan April 9, 2025 00:06
@tigrannajaryan tigrannajaryan dismissed their stale review April 9, 2025 01:55

PR updated

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just 2 minor comments.

Co-authored-by: Christophe Kamphaus <[email protected]>
@jsuereth jsuereth merged commit 9f80317 into open-telemetry:main Apr 10, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Entities Apr 10, 2025
@jsuereth jsuereth deleted the wip-entities-data-model branch April 10, 2025 16:42
@carlosalberto carlosalberto mentioned this pull request Apr 10, 2025
carlosalberto added a commit that referenced this pull request Apr 15, 2025
### Context

- Add context propagation through Environment Variables specification.

([#4454](#4454))
- On Propagators API, stabilize `GetAll` on the `TextMap` Extract.

([#4472](#4472))

### Traces

- Define sampling threshold field in OpenTelemetry TraceState; define
the behavior
of TraceIdRatioBased sampler in terms of W3C Trace Context Level 2
randomness.

([#4166](#4166))

### Metrics

- Clarify SDK behavior for Instrument Advisory Parameter.

([#4389](#4389))

### Logs

- Add `Enabled` opt-in operation to the `LogRecordProcessor`.

([#4439](#4439))
- Stabilize `Logger.Enabled`.

([#4463](#4463))
- Stabilize `EventName`.

([#4475](#4475))

### Baggage

- Add context (baggage) propagation through Environment Variables
specification.

([#4454](#4454))

### Resource

- Add Datamodel for Entities.

([#4442](#4442))

### SDK Configuration

- Convert declarative config env var substitution syntax to ABNF.

([#4448](#4448))
- List declarative config supported SDK extension plugin interfaces.

([#4452](#4452))

---------

Co-authored-by: Armin Ruech <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

10 participants