Introduce instrumentation classifications to metadata #13672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
changed the title
trask
approved these changes
Apr 10, 2025
| @@ -10,8 +10,8 @@ Run the doc generator: | |||
|
|
|||
| ## Instrumentation Hierarchy | |||
|
|
|||
| An "InstrumentationEntity" represents a module that that targets specific code in a framework/library/technology. | |||
| Each instrumentation uses muzzle to determine which versions of the target code it supports. | |||
| An "InstrumentationEntity" represents a module that that targets specific code in a | |||
There was a problem hiding this comment.
if you think of another word besides entity, that might be good since we have open-telemetry/opentelemetry-specification#4442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13468
Deprecates the
isLibraryInstrumentationlabel in the metadata.yaml file and replaces it withclassification.Introduces 3 classification types:
I am open to ideas around these particular names/groupings in case anyone has a different way of thinking about them.
The instrumentation-list.yaml output now includes these other non-library instrumentation modules, and omits the "target_versions" since they are not applicable.
Also removed the
instrumentationslabel within each instrumentation group, and instead just list each instrumentation.