-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpentelemetryOban to use semantic conventions 1.27 #435
base: main
Are you sure you want to change the base?
Update OpentelemetryOban to use semantic conventions 1.27 #435
Conversation
@danschultzer can you please confirm you have thoroughly reviewed the Messaging Specification for any new or changed attributes that are applicable as well as any other sections? As far as I can tell this was not performed since nothing has changed in the setup for opting into experimental attirbutes which is essentially the entire messaging specification. Please refer to bandit, phoenix, cowboy, etc to familiarize yourself with the expected API. It is not sufficient to just bump the dependency. Thanks |
Yes, it's all in the followup PR #436, which adheres as much as possible to 1.27 specs for messaging. But it'll introduce many breaking change. This PR only focuses on updating the dependency, but all the attributes are backwards compatible so I don't think it's necessary to force the changes here? FWIW the dependency was not locked to 0.2, but allowed the range |
Also one thing on all my PRs, I can update the changelog if it's preferred to do in the PR's. I'm not sure how the releases are managed. |
Right, 1.27 does introduce a lot of breaking changes which is why we want it done properly and not just publishing a version with an updated dep with no actual updates. By going to 1.27 we are saying it is 100% 1.27 compliant to our knowledge. That's why this is a difficult update and folks have to exercise some patience. It's the most difficult update we'll have to make and hopefully the last for a long time. |
I see, but then do we need to fixate the semantic conventions version to I was thinking of using this PR in a minor release to bump the semconv version (we could make the version here be It gets the current dependency conflict out of the way without also breaking everything for the end-user (but they will get deprecation warnings which I think is ok). |
We have to override the
:semantic_conversions
dep because oban requires~> 0.2
but most otel libraries here uses 1.27.Resolves #428