Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(broadway): update opentelemetry_semantic_attributes to SemConv 1.27 #419

Conversation

klacointe
Copy link

No description provided.

Copy link

linux-foundation-easycla bot commented Nov 22, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: klacointe / name: klacointe (d0b53a8)

@klacointe klacointe changed the title chore(broadway): update opentelemetry_semantic_attributes chore(broadway): update opentelemetry_semantic_attributes to SemConv 1.27 Nov 22, 2024
@klacointe
Copy link
Author

up ?

@lud-wj
Copy link

lud-wj commented Dec 3, 2024

+1 for this pr, this prevent us to upgrade our OTEL dependencies.

@bryannaegele
Copy link
Collaborator

bryannaegele commented Dec 27, 2024

@klacointe can you please confirm you have thoroughly reviewed the Messaging Specification for any new or changed attributes that are applicable? As far as I can tell this was not performed since nothing has changed in the setup for opting into experimental attirbutes which is essentially the entire messaging specification. Please refer to bandit, phoenix, cowboy, etc to familiarize yourself with the expected API.

It is not sufficient to just bump the dependency.

Thanks

@danschultzer
Copy link
Contributor

FWIW I've updated the attributes and span names to the 1.27 guidelines for oban: #436

Among other things the span name must be updated, and there's also a whole thing on creation context.

@klacointe
Copy link
Author

Closing in favor of #435 and #436

@klacointe klacointe closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants