Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/zpages] Add an option to enable expvar #11964

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

HongChenTW
Copy link

Description

Add an option to enable expvar, default is disable.

Link to tracking issue

Resolve #11081

Testing

Add a test case to verify the newly added option works.

extension/zpagesextension/factory.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.62%. Comparing base (ffcef93) to head (82be62c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11964   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         447      447           
  Lines       23739    23743    +4     
=======================================
+ Hits        21751    21755    +4     
  Misses       1613     1613           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add expvar handler to zpages extension
2 participants