[extension/zpages] Add an option to enable expvar #11217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolve open-telemetry#11081 Signed-off-by: Hong Chen <[email protected]>
Signed-off-by: Hong Chen <[email protected]>
#### Description All Testifylint rules are now fixed and ensured to be applied with golangci-lint. This removes the helper configuration in Makefile and tools module.
…emetry#11204) #### Description Depends on open-telemetry#11209 This PR is a non-breaking implementation of open-telemetry#10947. It adds a new module, `pipeline`, which houses a `pipeline.ID` and `pipeline.Signal`. `pipeline.ID` is used to identify a pipeline within the service. `pipeline.Signal` is uses to identify the signal associated to a pipeline. I do this work begrudgingly. As the PR shows, this is a huge refactor when done in a non-breaking way, will require 3 full releases, and doesn't benefit our [End Users or, in my opinion, our Component Developers or Collector Library Users](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#target-audiences). I view this refactor as a Nice-To-Have, not a requirement for Component 1.0. <!-- Issue number if applicable --> #### Link to tracking issue Works towards open-telemetry#9429
#### Description Fixes failing unit test TestProcessTelemetryWithHostProc under service/internal/proctelemetry/process_telemetry_linux_test.go due to incorrect metric name #### Link to tracking issue Fixes [open-telemetry#11221](open-telemetry#11221)
#### Description Need to update `pipeline` and `globalgate` versions to run `make update-otel` in Contrib
…1235) Signed-off-by: Bogdan Drutu <[email protected]>
#### Description As part of open-telemetry#11204 I left `host`'s implementation of `GetExporters` alone, thinking I didn't need to change a deprecated interface implementation. But `GetExporters` depends on `component.DataType`, so we won't be able to remove `component.DataType` unless `GetExporters` is updated to use `pipeline.Signal` instead. This PR deprecates the deprecated `GetExporters` interface with `GetExportersWithSignal`, which uses `pipeline.Signal`. Then we'll follow the process to rename `GetExportersWithSignal` back to `GetExporters`.
…#11250) Signed-off-by: Bogdan Drutu <[email protected]>
The following commands were run to prepare this release: - make chlog-update VERSION=v1.16.0/v0.110.0 - make prepare-release PREVIOUS_VERSION=1[.]15[.]0 RELEASE_CANDIDATE=1.16.0 MODSET=stable - make prepare-release PREVIOUS_VERSION=0[.]109[.]0 RELEASE_CANDIDATE=0.110.0 MODSET=beta
Signed-off-by: Hong Chen <[email protected]>
|
Hi team, seems I mis-merged the others' commits and accidentally add many participants, should I open another PR to fix this issue? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
hey @HongChenTW, since no one is answering, you can try to move your branch's HEAD to the last commit you worked on and take it again from there |
|
Thanks @johnmantios 👍, I'll take a look into the post, actually you also remind me that I had a PR here. |
yurishkuro
reviewed
Dec 20, 2024
| @@ -37,5 +37,6 @@ func TestUnmarshalConfig(t *testing.T) { | |||
| ServerConfig: confighttp.ServerConfig{ | |||
| Endpoint: "localhost:56888", | |||
| }, | |||
| EnableExpvar: false, | |||
There was a problem hiding this comment.
ineffectual, false is the default value fr bools
yurishkuro
reviewed
Dec 20, 2024
| @@ -33,7 +33,7 @@ extensions: | |||
| zpages: | |||
| ``` | |||
|
|
|||
| The full list of settings exposed for this exporter are documented [here](./config.go) | |||
| The full list of settings exposed for this extension are documented [here](./config.go) | |||
There was a problem hiding this comment.
mention new endpoint in the README?
There was a problem hiding this comment.
expvar route added to README in PR #11964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option to enable expvar, default is
disable.Link to tracking issue
Resolve #11081
Testing
Add a test case to verify the newly added option works.