Updates to Subscription#index view page #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the display of subscriptions for guest users, as it was calling id on nil before. It also includes a new Subscription scope :post_cart that filters out cart subscriptions for the Subscription#index view because they're not valid subscriptions yet. It updates the SubscriptionsController#index action to use the new scope.
mumoc
referenced
this pull request
in crowdint/spree-subscribe
Sep 4, 2013
[#55162364] Add spanish translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the display of subscriptions for guest users, as it was calling id on nil before.
It also includes a new Subscription scope
post_cartthat filters out cart subscriptions for theSubscription#indexview because they're not valid subscriptions yet. It updates theSubscriptionsController#indexaction to use the new scope.And lastly, it updates the
SubscriptionsControllerto useBaseControllerwhich includes authentication checks. Before this change you could view the subscription index without being logged in as an admin.