Skip to content

ci: correct SC2016 comment in crush workflow #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taoeffect merged 1 commit into from
Aug 4, 2026
Merged

ci: correct SC2016 comment in crush workflow #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/pull-review-crush.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,9 +512,11 @@ jobs:
# the token or the runner credentials — better no review than an
# unsandboxed one. The runner agent dirs are passed as positional
# arguments so the check probes the exact paths that were masked.
# The single quotes are intentional (SC2016): the variables must
# be expanded by the inner shell inside the sandbox, not by the
# outer shell, or the secret values would leak into the command.
# The single quotes are intentional (SC2016): $GH_TOKEN must be
# evaluated by the inner shell inside the sandbox. If the outer
# shell expanded it, the check would compare a non-empty literal
# and always report failure, and the value would be exposed in
# the process command line.
# shellcheck disable=SC2016
"${BWRAP[@]}" sh -c '
fail=0
Expand Down
Loading