ci: correct SC2016 comment in crush workflow - #299
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the inline ShellCheck (SC2016) suppression rationale in the “crush” pull-review workflow to reflect the correct threat model and functional behavior of the sandbox pre-flight check, aligning the workflow comment with Issue #298’s requirements.
Changes:
- Reword the SC2016 suppression comment to explain that
$GH_TOKENmust be expanded by the inner (sandboxed) shell. - Clarify the two real consequences of outer-shell expansion: a guaranteed false failure and exposure via the process command line.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/review AI review started. |
Advanced AI Review
Click to expand reviewI'll review the changes. Let me first read the full context of the modified file.I've reviewed the diff and read the surrounding context. This is a pure comment update addressing issue #298, replacing an inaccurate threat-model explanation with a correct one. Let me verify the technical claims against the actual check code.The change is a comment-only update that correctly replaces a misleading threat model. I traced the logic: No 🔴, 🟡, or meaningful ⚪️ issues found. The comment is technically accurate, grammatically correct, and directly resolves issue #298. No changes to the code logic were made, so there is nothing to break or conflict. Review generated using |
|
@taoeffect approved! ✅ |
@taoeffect I investigated the
spellcheckcomment and concluded thatmake lint-actionsrunsactionlint, which invokesshellcheckonly if theshellcheckbinary is on PATH. Since it's not installed in the lint-actions job in CI this was never firing in CI. I added the comment previously in order to suppress (my) local runs that would otherwise flag it.Closes #298
AI Disclosure
Co-authored with: Opus 5