Expand on STM Bytes test #547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the extension of the
STM Bytes
test mentioned in #546.It targets 5 more bindings from the Bytes module - a decent increase over the existing 7.
I lost momentum when I hit the many index/contains/is_valid bindings covered by
src/bytes/lin_tests.ml
... 😬While writing this, I noticed thatUtil.Pp
only covers up tocst3
- and similarly forQCheck.Gen.map{,2,3}
.I think it would be a good idea to extend both to cover up to🙂 Edit: fixed - see below{cst,map}5
.