Skip to content

Expand on STM Bytes test #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 8, 2025
Merged

Expand on STM Bytes test #547

merged 10 commits into from
Apr 8, 2025

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Mar 30, 2025

This is the extension of the STM Bytes test mentioned in #546.
It targets 5 more bindings from the Bytes module - a decent increase over the existing 7.
I lost momentum when I hit the many index/contains/is_valid bindings covered by src/bytes/lin_tests.ml... 😬

While writing this, I noticed that Util.Pp only covers up to cst3 - and similarly for QCheck.Gen.map{,2,3}.
I think it would be a good idea to extend both to cover up to {cst,map}5. 🙂 Edit: fixed - see below

@jmid jmid force-pushed the expand-stm-bytes branch from f42fce0 to a30ef4d Compare April 7, 2025 11:46
@jmid
Copy link
Collaborator Author

jmid commented Apr 7, 2025

While writing this, I noticed that Util.Pp only covers up to cst3 - and similarly for QCheck.Gen.map{,2,3}. I think it would be a good idea to extend both to cover up to {cst,map}5. 🙂

  • I've now released qcheck-core.0.25 containing QCheck.Gen.map{,4,5} and therefore bumped the lower bound to that, and removed the temporary map4 definition again
  • I've also added Util.Pp.cst5 for uniformity and a CHANGES entry for that and cst4
  • Finally I've rebased the PR on main, reordered and cleaned up the commits

@jmid
Copy link
Collaborator Author

jmid commented Apr 8, 2025

CI summary: all 36 workflows passed

@jmid jmid merged commit e1ccbb0 into main Apr 8, 2025
42 of 44 checks passed
@jmid jmid deleted the expand-stm-bytes branch April 8, 2025 09:35
@jmid
Copy link
Collaborator Author

jmid commented Apr 8, 2025

CI summary for merge to main: all 37 workflows passed
(an MSVC workflow failed its net connection and needed rerunning though)

@jmid jmid mentioned this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant