Skip to content

Conversation

@rytswd
Copy link
Member

@rytswd rytswd commented Oct 10, 2025

No description provided.

@rytswd rytswd marked this pull request as draft October 10, 2025 23:49
@rytswd rytswd changed the title DRAFT: Etcd API and CRD Etcd API and CRD Oct 12, 2025
@rytswd rytswd marked this pull request as ready for review October 12, 2025 13:39
// +kubebuilder:object:root=true
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="Ready",type=boolean,JSONPath=`.status.ready`
// +kubebuilder:printcolumn:name="Replicas",type=string,JSONPath=`.status.readyReplicas`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// +kubebuilder:printcolumn:name="Replicas",type=string,JSONPath=`.status.readyReplicas`
// +kubebuilder:printcolumn:name="Ready Replicas",type=string,JSONPath=`.status.readyReplicas`

Co-authored-by: fernando-villalba <[email protected]>
Co-authored-by: Robert Cambridge <[email protected]>
@rytswd rytswd requested a review from rcambrj October 13, 2025 09:01
@rcambrj rcambrj mentioned this pull request Oct 13, 2025
@rytswd
Copy link
Member Author

rytswd commented Oct 13, 2025

@fernando-villalba @rcambrj
If you could just do a quick scan, that would be appreciated!

@rytswd rytswd merged commit 0a04b22 into main Oct 14, 2025
9 checks passed
@rytswd rytswd deleted the etcd-api-and-crd branch October 14, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants