Add etcd controller code #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs further testing and is breaking in local development due to the API spec mismatch, which is expected as all the API updates have not made to the main branch yet.
fernando-villalba
approved these changes
Oct 13, 2025
rytswd
commented
Oct 14, 2025
Comment on lines
+259
to
+267
| // SetupWithManager sets up the controller with the Manager. | ||
| // TODO: This is missing test coverage, and will need to use envtest setup. | ||
| func (r *EtcdReconciler) SetupWithManager(mgr ctrl.Manager) error { | ||
| return ctrl.NewControllerManagedBy(mgr). | ||
| For(&multigresv1alpha1.Etcd{}). | ||
| Owns(&appsv1.StatefulSet{}). | ||
| Owns(&corev1.Service{}). | ||
| Complete(r) | ||
| } |
Member
Author
There was a problem hiding this comment.
This is the code path that's not yet tested.
|
|
||
| require ( | ||
| github.com/google/go-cmp v0.7.0 | ||
| github.com/numtide/multigres-operator/api v0.0.0-20251010210109-0981dc938d36 |
Member
Author
There was a problem hiding this comment.
- Ensure go.mod pulls in the correct version reference before merging
Some of the test cases have been moved around, formatted for better clarity, extra test spec added, and unused dependencies removed.
fernando-villalba
approved these changes
Oct 14, 2025
rcambrj
approved these changes
Oct 14, 2025
Member
Author
|
Ah I forgot to update the API go.mod reference, will follow up with another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the implementation logic is in place, as well as test coverage is near 100% test. There is only one function that's not being triggered due to the lack of envtest setup at the moment, and will be probably tackled in a separate PR.
Note that this now uses #15 and #23 for CRDs. Also, this must get the go.mod version reference update for
apidirectory.