-
Notifications
You must be signed in to change notification settings - Fork 2.6k
cleanup(repo): use mise for agent toolchain installs #33299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
b002480
281e750
de51935
f513d91
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,184 +1,76 @@ | ||
| common-env-vars: &common-env-vars | ||
| GIT_AUTHOR_EMAIL: [email protected] | ||
| GIT_AUTHOR_NAME: Test | ||
| GIT_COMMITTER_EMAIL: [email protected] | ||
| GIT_COMMITTER_NAME: Test | ||
| SELECTED_PM: 'pnpm' | ||
| NX_NATIVE_LOGGING: 'nx::native::db' | ||
| # These are need for build and link validation for next.js and astro apps | ||
| NEXT_PUBLIC_ASTRO_URL: 'https://master--nx-docs.netlify.app' | ||
| NX_DEV_URL: 'https://canary.nx.dev' | ||
|
|
||
| common-init-steps: &common-init-steps | ||
| - name: Checkout | ||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/checkout/main.yaml' | ||
|
|
||
| - name: Cache restore | ||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/cache/main.yaml' | ||
| inputs: | ||
| key: 'pnpm-lock.yaml' | ||
| paths: .pnpm-store | ||
| base-branch: 'master' | ||
|
|
||
| # reads mise.toml and installs toolchains needed for repo | ||
| - name: Setup toolchains | ||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/install-mise/main.yaml' | ||
|
|
||
| - name: Verify toolchain versions | ||
| script: | | ||
| echo "mise: $(mise --version)" | ||
| echo "node: $(node --version)" | ||
| echo "pnpm: $(pnpm --version)" | ||
| echo "bun: $(bun --version)" | ||
| echo "rust: $(rustc --version) - $(cargo --version)" | ||
| echo "dotnet: $(dotnet --version)" | ||
| echo "java: $(javac --version)" | ||
| - name: Install system deps | ||
| script: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y ca-certificates lsof libvips-dev libglib2.0-dev libgirepository1.0-dev zip unzip | ||
| - name: Pnpm Install from lockfile | ||
| script: | | ||
| pnpm install --frozen-lockfile | ||
| - name: Install browsers | ||
| script: | | ||
| pnpm exec cypress install | ||
| pnpm exec playwright install --with-deps | ||
| - name: Install rust deps | ||
| script: | | ||
| cargo fetch | ||
| - name: Setup gradle | ||
| script: | | ||
| ./gradlew wrapper | ||
| ./gradlew --version | ||
| - name: Configure git metadata (needed for lerna smoke tests) | ||
| script: | | ||
| git config --global user.email [email protected] | ||
| git config --global user.name "Test Test" | ||
| launch-templates: | ||
| linux-large: | ||
| resource-class: 'docker_linux_amd64/large' | ||
| image: 'us-east1-docker.pkg.dev/nxcloudoperations/nx-cloud/nx-agents-base-images:ubuntu22.04-node20.19-v1' | ||
| env: | ||
| GIT_AUTHOR_EMAIL: [email protected] | ||
| GIT_AUTHOR_NAME: Test | ||
| GIT_COMMITTER_EMAIL: [email protected] | ||
| GIT_COMMITTER_NAME: Test | ||
| SELECTED_PM: 'pnpm' | ||
| NX_NATIVE_LOGGING: 'nx::native::db' | ||
| # These are need for build and link validation for next.js and astro apps | ||
| NEXT_PUBLIC_ASTRO_URL: 'https://master--nx-docs.netlify.app' | ||
| NX_DEV_URL: 'https://canary.nx.dev' | ||
| init-steps: | ||
| - name: Checkout | ||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/checkout/main.yaml' | ||
|
|
||
| - name: Check Node Version | ||
| script: node --version | ||
|
|
||
| - name: Cache restore | ||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/cache/main.yaml' | ||
| inputs: | ||
| key: 'pnpm-lock.yaml' | ||
| paths: .pnpm-store | ||
| base-branch: 'master' | ||
|
|
||
| - name: Install zip and unzip | ||
| script: sudo apt-get -yqq install zip unzip | ||
|
|
||
| - name: Install bun | ||
| script: | | ||
| curl -fsSL https://bun.sh/install | bash | ||
| echo "BUN_INSTALL=$HOME/.bun" >> $NX_CLOUD_ENV | ||
| echo "PATH=$HOME/.bun/bin:$PATH" >> $NX_CLOUD_ENV | ||
| - name: Check bun | ||
| script: | | ||
| bun --version | ||
| - name: Install e2e deps | ||
| script: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y ca-certificates lsof libvips-dev libglib2.0-dev libgirepository1.0-dev | ||
| - name: Pnpm Install from lockfile | ||
| script: | | ||
| pnpm install --frozen-lockfile | ||
| - name: Install Browsers | ||
| script: | | ||
| pnpm exec cypress install | ||
| pnpm exec playwright install --with-deps | ||
| - name: Install Rust | ||
| script: | | ||
| curl --proto '=https' --tlsv1.3 https://sh.rustup.rs -sSf | sh -s -- -y | ||
| source "$HOME/.cargo/env" | ||
| rustup toolchain install 1.70.0 | ||
| - name: Configure git metadata (needed for lerna smoke tests) | ||
| script: | | ||
| git config --global user.email [email protected] | ||
| git config --global user.name "Test Test" | ||
| - name: Load Cargo Env | ||
| script: echo "PATH=$HOME/.cargo/bin:$PATH" >> $NX_CLOUD_ENV | ||
|
|
||
| - name: Install Rust Dependencies | ||
| script: | | ||
| cargo fetch | ||
| - name: Setup Java 21 | ||
| script: | | ||
| sudo apt update | ||
| sudo apt install -y openjdk-21-jdk | ||
| sudo update-alternatives --set java /usr/lib/jvm/java-21-openjdk-amd64/bin/java | ||
| java -version | ||
| - name: Setup Gradle | ||
| script: | | ||
| ./gradlew wrapper | ||
| ./gradlew --version | ||
| - name: Setup .NET 9 | ||
| script: | | ||
| wget https://packages.microsoft.com/config/ubuntu/22.04/packages-microsoft-prod.deb -O packages-microsoft-prod.deb | ||
| sudo dpkg -i packages-microsoft-prod.deb | ||
| sudo apt-get update | ||
| sudo apt-get install -y dotnet-sdk-9.0 | ||
| dotnet --version | ||
| env: *common-env-vars | ||
| init-steps: *common-init-steps | ||
|
|
||
| linux-extra-large: | ||
| resource-class: 'docker_linux_amd64/extra_large' | ||
| image: 'us-east1-docker.pkg.dev/nxcloudoperations/nx-cloud/nx-agents-base-images:ubuntu22.04-node20.19-v1' | ||
| env: | ||
| GIT_AUTHOR_EMAIL: [email protected] | ||
| GIT_AUTHOR_NAME: Test | ||
| GIT_COMMITTER_EMAIL: [email protected] | ||
| GIT_COMMITTER_NAME: Test | ||
| SELECTED_PM: 'pnpm' | ||
| NX_NATIVE_LOGGING: 'nx::native::db' | ||
| # These are need for build and link validation for next.js and astro apps | ||
| NEXT_PUBLIC_ASTRO_URL: 'https://master--nx-docs.netlify.app' | ||
| NX_DEV_URL: 'https://canary.nx.dev' | ||
| init-steps: | ||
| - name: Checkout | ||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/checkout/main.yaml' | ||
|
|
||
| - name: Check Node Version | ||
| script: node --version | ||
|
|
||
| - name: Cache restore | ||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/cache/main.yaml' | ||
| inputs: | ||
| key: 'pnpm-lock.yaml' | ||
| paths: .pnpm-store | ||
| base-branch: 'master' | ||
|
|
||
| - name: Install zip and unzip | ||
| script: sudo apt-get -yqq install zip unzip | ||
|
|
||
| - name: Install bun | ||
| script: | | ||
| curl -fsSL https://bun.sh/install | bash | ||
| echo "BUN_INSTALL=$HOME/.bun" >> $NX_CLOUD_ENV | ||
| echo "PATH=$HOME/.bun/bin:$PATH" >> $NX_CLOUD_ENV | ||
| - name: Check bun | ||
| script: | | ||
| bun --version | ||
| - name: Install e2e deps | ||
| script: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y ca-certificates lsof libvips-dev libglib2.0-dev libgirepository1.0-dev | ||
| - name: Pnpm Install from lockfile | ||
| script: | | ||
| pnpm install --frozen-lockfile | ||
| - name: Install Browsers | ||
| script: | | ||
| pnpm exec cypress install | ||
| pnpm exec playwright install --with-deps | ||
| - name: Install Rust | ||
| script: | | ||
| curl --proto '=https' --tlsv1.3 https://sh.rustup.rs -sSf | sh -s -- -y | ||
| source "$HOME/.cargo/env" | ||
| rustup toolchain install 1.70.0 | ||
| - name: Configure git metadata (needed for lerna smoke tests) | ||
| script: | | ||
| git config --global user.email [email protected] | ||
| git config --global user.name "Test Test" | ||
| - name: Load Cargo Env | ||
| script: echo "PATH=$HOME/.cargo/bin:$PATH" >> $NX_CLOUD_ENV | ||
|
|
||
| - name: Install Rust Dependencies | ||
| script: | | ||
| cargo fetch | ||
| - name: Setup Java 21 | ||
| script: | | ||
| sudo apt update | ||
| sudo apt install -y openjdk-21-jdk | ||
| sudo update-alternatives --set java /usr/lib/jvm/java-21-openjdk-amd64/bin/java | ||
| java -version | ||
| - name: Setup Gradle | ||
| script: | | ||
| ./gradlew wrapper | ||
| ./gradlew --version | ||
| - name: Setup .NET 9 | ||
| script: | | ||
| wget https://packages.microsoft.com/config/ubuntu/22.04/packages-microsoft-prod.deb -O packages-microsoft-prod.deb | ||
| sudo dpkg -i packages-microsoft-prod.deb | ||
| sudo apt-get update | ||
| sudo apt-get install -y dotnet-sdk-9.0 | ||
| dotnet --version | ||
| env: *common-env-vars | ||
| init-steps: *common-init-steps | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,5 +1,6 @@ | ||||||||||||||||||||||||||||||||||
| [tools] | ||||||||||||||||||||||||||||||||||
| dotnet = "9" | ||||||||||||||||||||||||||||||||||
| java = "24" | ||||||||||||||||||||||||||||||||||
| node = "24" | ||||||||||||||||||||||||||||||||||
| node = "20" | ||||||||||||||||||||||||||||||||||
| rust = "1.90.0" | ||||||||||||||||||||||||||||||||||
barbados-clemens marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||||||||||||||
| bun = "1.3" | ||||||||||||||||||||||||||||||||||
barbados-clemens marked this conversation as resolved.
Show resolved
Hide resolved
Comment on lines
1
to
+6
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Missing pnpm in toolchain The workflow uses pnpm extensively (lines 44, 48-49 in agents.yaml) but pnpm is not listed in the mise.toml toolchain configuration. If mise overrides the base image's Node installation, pnpm may not be available, causing [tools]
pnpm = "latest" # or specific version
Suggested change
Spotted by Graphite Agent |
||||||||||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.