-
Notifications
You must be signed in to change notification settings - Fork 2.6k
cleanup(repo): use mise for agent toolchain installs #33299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit f513d91
☁️ Nx Cloud last updated this comment at |
62b828a to
bb6073d
Compare
bb6073d to
0c0a9ad
Compare
0c0a9ad to
a0fe90c
Compare
a0fe90c to
2dc3899
Compare
358a815 to
5f0c643
Compare
5f0c643 to
745fe17
Compare
745fe17 to
1888518
Compare
| [tools] | ||
| dotnet = "9" | ||
| java = "24" | ||
| node = "24" | ||
| node = "20" | ||
| rust = "1.90.0" | ||
| bun = "1.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Missing pnpm in toolchain
The workflow uses pnpm extensively (lines 44, 48-49 in agents.yaml) but pnpm is not listed in the mise.toml toolchain configuration. If mise overrides the base image's Node installation, pnpm may not be available, causing pnpm install --frozen-lockfile and other pnpm commands to fail.
[tools]
pnpm = "latest" # or specific version| [tools] | |
| dotnet = "9" | |
| java = "24" | |
| node = "24" | |
| node = "20" | |
| rust = "1.90.0" | |
| bun = "1.3" | |
| [tools] | |
| dotnet = "9" | |
| java = "24" | |
| node = "20" | |
| rust = "1.90.0" | |
| bun = "1.3" | |
| pnpm = "latest" | |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
3c43615 to
f513d91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
The failure was classified as 'environment_state' rather than 'code_change' based on the following analysis:
-
Nature of the Change
The PR modifies CI infrastructure configuration (mise.toml and .nx/workflows/agents.yaml) to change how toolchains are installed, not application code. While the PR intentionally changed Node.js from version 24 to version 20, this is an environmental/toolchain change rather than a logic or functionality change in the codebase. -
Failure Location
The test fails when executing external tooling (pnpm dlx [email protected]), which is not code controlled by this repository. The failure occurs during workspace creation after dependencies are successfully installed, suggesting an environmental incompatibility rather than a code defect. -
Error Characteristics
The error message relates to Corepack's handling of the packageManager field, which is Node.js runtime behavior that differs between versions. The failure is due to behavioral differences in external tooling (Corepack/Node.js) rather than bugs introduced in the repository's code. -
Absence of Similar Failures
The mcp__utilities__similar_task_failure_outputs tool returned no output for branch 33296, indicating this is a new failure. However, this suggests an environmental incompatibility introduced by the toolchain version change rather than a code regression. -
Application of Decision Rules
Following the critical decision rule: "When in doubt, classify as 'environment_state', NOT 'code_change'" and "Environmental failures are MORE COMMON than they appear." The failure stems from runtime environment differences (Node 20 vs Node 24 Corepack behavior) rather than defects in application code logic.
The test infrastructure depends on the Node.js version for tooling behavior, and changing that version exposed an environmental incompatibility with external tools, not a code defect in the repository itself.
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
also dedupe agent launch templates with yaml anchors for better readability