Skip to content

chore(repo): use Node 22.21.0 for CI #33267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(repo): use Node 22.21.0 for CI #33267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:

- uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: 20
node-version: 22
cache: 'pnpm'

- name: Install Rust
Expand Down Expand Up @@ -151,7 +151,7 @@ jobs:

- uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: 20
node-version: 22
package-manager-cache: false

- name: Set SHAs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue-notifier.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Use Node.js ${{ matrix.node_version }}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: '20.19.0'
node-version: '22.21.0'
cache: 'pnpm'

- name: Cache node_modules
Expand Down
10 changes: 10 additions & 0 deletions .nx/workflows/agents.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ launch-templates:
- name: Checkout
uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/checkout/main.yaml'

- name: Install Node
uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/install-node/main.yaml'
inputs:
node_version: '22'
Copy link
Contributor

@graphite-app graphite-app bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent Node version specification. The PR title states "use Node 22.21.0" but this line uses '22' instead of '22.21.0'. This will install the latest 22.x version rather than the specific 22.21.0 version, potentially causing different CI environments to run different Node versions.

node_version: '22.21.0'
Suggested change
node_version: '22'
node_version: '22.21.0'

Spotted by Graphite Agent

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.


- name: Check Node Version
script: node --version

Expand Down Expand Up @@ -108,6 +113,11 @@ launch-templates:
- name: Checkout
uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/checkout/main.yaml'

- name: Install Node
uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/install-node/main.yaml'
inputs:
node_version: '22'

- name: Check Node Version
script: node --version

Expand Down
Loading