-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(repo): use Node 22.21.0 for CI #33267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit ea57784
☁️ Nx Cloud last updated this comment at |
ef4b607 to
31bba6a
Compare
31bba6a to
ea57784
Compare
| - name: Install Node | ||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/install-node/main.yaml' | ||
| inputs: | ||
| node_version: '22' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent Node version specification. The PR title states "use Node 22.21.0" but this line uses '22' instead of '22.21.0'. This will install the latest 22.x version rather than the specific 22.21.0 version, potentially causing different CI environments to run different Node versions.
node_version: '22.21.0'| node_version: '22' | |
| node_version: '22.21.0' |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
This is classified as an environment_state issue rather than a code_change issue because:
-
Node.js version upgrade: The PR upgrades Node from version 20 to 22 in CI workflows (.github/workflows/ci.yml and .github/workflows/issue-notifier.yml). Node 22 has different module handling and may affect how Jest processes TypeScript files.
-
Widespread, identical failures: Multiple unrelated projects (nx-dev-ui-sponsor-card, nx-dev-ui-markdoc, nx-dev-data-access-documents, dotnet, nx-dev, module-federation, nx-dev-feature-ai, rsbuild) all fail with the exact same error pattern: "Failed to parse the TypeScript config file" with "Unexpected token 'export'". This indicates a systemic environment issue rather than specific code problems.
-
No jest.config.ts modifications: The PR diff shows no changes to any jest.config.ts files or Jest-related configuration. The code changes are focused on reverting daemon messaging serialization from V8 back to JSON.
-
Nature of the error: The error "Unexpected token 'export'" indicates Jest cannot parse ES module syntax in TypeScript files. This is a transpilation/compilation environment issue, not a logic error in the code.
-
Code changes are unrelated: The PR reverts daemon socket messaging changes - removing V8 serialization, simplifying message delimiters from 'NX_MSG_END\x04' back to '\x04', and cleaning up related code. None of these changes would affect Jest's ability to parse TypeScript configuration files.
-
Node.js warning confirms the issue: The warning message "Failed to load the ES module: ... Make sure to set "type": "module" in the nearest package.json file or use the .mjs extension" indicates a Node.js module system configuration issue that is environment-dependent.
The failures stem from the Node 22 upgrade changing how modules are handled, which affects Jest's TypeScript transpilation process, not from any intentional code changes made in this PR.
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
Update workflows to Node 22.21.0.