plugins/hunk: init #3293
plugins/hunk: init #3293
Conversation
jalil-salame
force-pushed
the
push-yxsyxkonwotv
branch
from
80f89a2 to
54d3843
Compare
plugins/by-name/hunk/default.nix
Outdated
| extraOptions = { | ||
| fileTypeIcons = lib.mkEnableOption '' | ||
| Enable file type icons in the file tree. | ||
| ''; | ||
| }; |
There was a problem hiding this comment.
I have missed something or this option is only used in the warning?
There was a problem hiding this comment.
Nope, only in the warning, I tried setting web-devicons to true there, but it threw a warning.
jalil-salame
force-pushed
the
push-yxsyxkonwotv
branch
2 times, most recently
from
3de2637 to
714e66e
Compare
plugins/by-name/hunk/default.nix
Outdated
| extraOptions = { | ||
| fileTypeIcons = lib.mkEnableOption '' | ||
| warning if file type icons are not available. | ||
| ''; | ||
| }; |
There was a problem hiding this comment.
Having an enable option for a warning feels like an anti-pattern
| extraOptions = { | |
| fileTypeIcons = lib.mkEnableOption '' | |
| warning if file type icons are not available. | |
| ''; | |
| }; |
jalil-salame
force-pushed
the
push-yxsyxkonwotv
branch
from
714e66e to
286f4e0
Compare
Add support for [hunk.nvim][1], a plugin for splitting diffs. Also add myself as a maintainer for it. [1]: https://github.com/julienvincent/hunk.nvim
jalil-salame
force-pushed
the
push-yxsyxkonwotv
branch
from
286f4e0 to
bd1da3d
Compare
| jalil-salame = { | ||
| email = "[email protected]"; | ||
| github = "jalil-salame"; | ||
| githubId = 60845989; | ||
| name = "Jalil David Salamé Messina"; | ||
| keys = [ { fingerprint = "7D6B 4D8F EBC5 7CBC 09AC 331F DA33 17E7 5BE9 485C"; } ]; | ||
| }; |
There was a problem hiding this comment.
Can you move this change into a dedicated commit, so you end up with two:
maintainers: add jalil-salameplugins/hunk: init
(in that order)
| Either `plugins.web-devicons` or `plugins.mini`* must be enabled to have icons in the file tree. | ||
|
|
||
| *If using `plugins.mini`, you must enable the `icons` module. |
There was a problem hiding this comment.
Need to escape the *, as markdown uses them for italics and bullet points.
| Either `plugins.web-devicons` or `plugins.mini`* must be enabled to have icons in the file tree. | |
| *If using `plugins.mini`, you must enable the `icons` module. | |
| Either `plugins.web-devicons` or `plugins.mini`\* must be enabled to have icons in the file tree. | |
| \*If using `plugins.mini`, you must enable the `icons` module. |
Also, "must" feels too strong for an optional dependency. I'd suggest something like:
If you wish to display icons in the file tree, you should enable either
plugins.web-deviconsorplugins.mini. If usingplugins.mini, you must enable theiconsmodule.
?
| with-web-devicons = { | ||
| plugins.hunk = { | ||
| enable = true; | ||
| fileTypeIcons = true; |
There was a problem hiding this comment.
CI failure:
error: The option `plugins.hunk.fileTypeIcons' does not exist.
I guess this was missed while resolving #3293 (comment)?
| fileTypeIcons = true; |
| with-mini = { | ||
| plugins.hunk = { | ||
| enable = true; | ||
| fileTypeIcons = true; |
There was a problem hiding this comment.
Same CI failure
| fileTypeIcons = true; |
| package = "hunk-nvim"; | ||
|
|
||
| description = '' | ||
| A tool for splitting diffs in Neovim |
There was a problem hiding this comment.
Grammar nit:
| A tool for splitting diffs in Neovim | |
| A tool for splitting diffs in Neovim. |
Add support for hunk.nvim, a plugin for splitting diffs.
Also add myself as a maintainer for it.