gotify-desktop: init module #8208
Open
+202
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
reviewed
Dec 3, 2025
Comment on lines
4
to
6
| gotify-dekstop-str-token = ./gotify-dekstop-str-token.nix; | ||
| gotify-dekstop-command-token = ./gotify-dekstop-command-token.nix; | ||
| gotify-dekstop-extra-config = ./gotify-dekstop-extra-config.nix; |
Collaborator
There was a problem hiding this comment.
Would be helpful to have tests that verify settings not included when not configured.
Contributor
Author
There was a problem hiding this comment.
See comment bellow.
modules/services/gotify-desktop.nix
Outdated
| (lib.hm.assertions.assertPlatform "services.gotify-desktop" pkgs lib.platforms.linux) | ||
| ]; | ||
|
|
||
| xdg.configFile."gotify-desktop/config.toml".source = configToml; |
Collaborator
There was a problem hiding this comment.
Generally prefer checking if anything has been configured, at all before creating a file.
Contributor
Author
There was a problem hiding this comment.
The url and token settings are required, so I elected to give them their own module option. They are added to the user set optional settings. Meaning settings is guaranteed to be set with a valid module definition.
The original implementation was subpar so this wasn't obvious. I changed the implementation be more nixy.
Joker9944
force-pushed
the
gotify-desktop
branch
2 times, most recently
from
802bd6d to
3cf5447
Compare
Co-authored-by: Austin Horstman <[email protected]>
Joker9944
force-pushed
the
gotify-desktop
branch
from
3cf5447 to
dac9ea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new service module: gotify-desktop a Gotify message forward daemon.
Notable things:
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.