Skip to content

Conversation

@augtheo
Copy link

@augtheo augtheo commented Nov 11, 2025

Description

Allow configuring PubkeyAuthentication in the ssh config through module options.

This is a pretty straight-forward module-option -> config key change.

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@home-manager-ci home-manager-ci bot requested a review from rycee November 11, 2025 05:22
@ambroisie
Copy link
Contributor

This PR looks fine.

However, we should migrate to a freeform module, to avoid even more PRs in the future (this isn't the first one).

@teto
Copy link
Collaborator

teto commented Nov 16, 2025

same situation as in #8073. While the PR is fine, once it's merged, it will add an additional migration path when implementing freeform module (grep "freeformType" in source code to see examples).
Would you be interested in doing such a migration ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants