Skip to content

Conversation

@OliverGeneser
Copy link

Description

Add the option to specify kexAlgorithms in SSH matchBlocks.

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@home-manager-ci home-manager-ci bot requested a review from rycee October 27, 2025 20:38
@OliverGeneser OliverGeneser force-pushed the ssh-kex-algo branch 2 times, most recently from fca5e36 to e830384 Compare October 28, 2025 20:05
This commit adds the option to add kexAlgorithms as an matchBlock
option with updated test case.
@teto
Copy link
Collaborator

teto commented Oct 30, 2025

can't we make that a freeform module instead ? a la rfc42

@OliverGeneser
Copy link
Author

can't we make that a freeform module instead ? a la rfc42

I think it should be a separate PR and this should be merge as it has already been approved.
But what do you think @khaneliman should I refactor this PR and use freeformType? Or a separate PR?

@khaneliman
Copy link
Collaborator

Am seeing a pattern approaching. There's a lot of customization possible with SSH and perhaps we need a refactor instead of keep shoveling in new options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants