-
Notifications
You must be signed in to change notification settings - Fork 4
feat(alarms): Error handling for workspace dependency #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Ahalya-ni
merged 24 commits into
main
from
users/ahalya/feat/alarms/error-handling-for-dependency
Oct 15, 2025
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
0c53ca4
initial commit
Ahalya-ni 23b4863
added workspace changes
Ahalya-ni d6e6310
updated test files
Ahalya-ni ce2920c
remove workspace workflow changes
Ahalya-ni dcf956f
updated test
Ahalya-ni cfeec13
rename methods name
Ahalya-ni 9fbb9a5
updated test
Ahalya-ni 136b493
added extra assertion in count editor unit test
Ahalya-ni fe7518b
resolve comments
Ahalya-ni 3831ad9
added workspace changes
Ahalya-ni 20f45d9
remove unwanted changes
Ahalya-ni 8ac7746
resolve self review comments
Ahalya-ni ded8f56
added few more tests
Ahalya-ni 2562af5
fix indentation
Ahalya-ni 9934724
used constructor instead of private method instance creation
Ahalya-ni 11eeaf8
added error handling
Ahalya-ni be533e5
Merge branch 'main' of https://github.com/ni/systemlink-grafana-plugi…
Ahalya-ni 66e4b78
resolve conflicts
Ahalya-ni 8c9abc4
remove unwanted changes
Ahalya-ni b9ec8af
add constant and update test
Ahalya-ni 6d09376
update test
Ahalya-ni cc3715b
address comments
Ahalya-ni f7a223a
remove break for default case in switch
Ahalya-ni e46a536
update test to simulate real flow
Ahalya-ni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
src/datasources/alarms/constants/AlarmsQueryEditor.constants.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.