feat(alarms): Error handling for workspace dependency #428
+106
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Base automatically changed from
users/ahalya/feat/alarms/workspace-cache
to
main
October 9, 2025 11:17
… into users/ahalya/feat/alarms/error-handling-for-dependency
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
manisha-ni
approved these changes
Oct 10, 2025
src/datasources/alarms/constants/AlarmsQueryEditor.constants.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Ahalya-ni
requested review from
hemkumarrao-ni,
kartheeswaran-ni and
ushakanagaraj-ni
as code owners
kartheeswaran-ni
approved these changes
Oct 15, 2025
| expect(container.getByText('WorkspaceName')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('should display error title and description when error occurs', async () => { |
There was a problem hiding this comment.
In run time, this component will be rendered first and the load workspace method will be called, right?
So, I feel errorTitle and errorDescription should be set inside the mockDatasource.loadWorkspaces spy.
Isn't that feasible?
| }) | ||
| ); | ||
|
|
||
| private handleDependenciesError(error: unknown): void { |
There was a problem hiding this comment.
This method seems to be common across data sources. I don't know why we are duplicating things. Please create a TD outside of this feature to move these methods to shared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
User Story 3283306: FE | Error Handling of query builder
Task 3249471: Error handling for workspace cache
This PR introduces error handling for dependencies such as workspaces.
👩💻 Implementation
extractErrorInfoto retrieve error details (status code and message), and store error messages in theAlarmsDataSourceCorefile.ERROR_SEVERITY_WARNING, to represent the warning severity. This will be reused across components for various query types (list alarms, alarms count, and alarm trend).FloatingError.🧪 Testing
Added unit tests
✅ Checklist