Skip to content

Conversation

mikeprosserni
Copy link
Contributor

@mikeprosserni mikeprosserni commented Sep 29, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • [ ] I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

This PR ensures there are examples for how to use Waveforms for: analog in, analog out, digital in, and digital out.

Preexisting examples:
examples\analog_in\voltage_acq_int_clk_wfm.py
examples\digital_in\acq_dig_port_int_clk_wfm.py

Added examples:
examples/analog_in/voltage_acq_int_clk_plot_wfm.py
examples/digital_out/cont_gen_dig_port_int_clk_wfm.py

Updated examples:
examples/analog_out/gen_voltage_wfm_int_clk.py

Why should this Pull Request be merged?

AB#3315079

What testing has been done?

Ran the examples locally.

@mikeprosserni mikeprosserni marked this pull request as ready for review September 29, 2025 18:24
Copy link
Contributor

github-actions bot commented Sep 29, 2025

Test Results

    38 files  ± 0      38 suites  ±0   1h 3m 30s ⏱️ +43s
 2 879 tests + 2   2 243 ✅ ±0    636 💤 + 2  0 ❌ ±0 
49 464 runs  +48  40 280 ✅ ±0  9 184 💤 +48  0 ❌ ±0 

Results for commit 8734aa1. ± Comparison against base commit d81eccf.

This pull request skips 1 and un-skips 1 tests.
tests.acceptance.test_examples ‑ test___shipping_example___run___no_errors[library_init_kwargs-example_path38]
tests.acceptance.test_examples ‑ test___shipping_example___run___no_errors[library_init_kwargs-example_path39]

♻️ This comment has been updated with latest results.

@bkeryan bkeryan merged commit b64228e into master Sep 30, 2025
27 checks passed
@bkeryan bkeryan deleted the users/mprosser/task-3315079-add-wfm-examples branch September 30, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants