Skip to content

Create an XYData class #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 8, 2025
Merged

Create an XYData class #204

merged 16 commits into from
Oct 8, 2025

Conversation

mjohanse-emr
Copy link
Contributor

@mjohanse-emr mjohanse-emr commented Sep 29, 2025 •
edited
Loading

What does this Pull Request accomplish?

Creates an XYData python class to back to the xy_data protobuf type.

Why should this Pull Request be merged?

Implements the nitypes portion of AB#3266236

What testing has been done?

New unit tests added. All unit tests pass. Also mypy, pyright, styleguide.

@mjohanse-emr
Create an XYData class
14f7e89 
Signed-off-by: Michael Johansen <[email protected]>
@mjohanse-emr mjohanse-emr requested a review from csjall September 29, 2025 21:32
mjohanse-emr
mjohanse-emr commented Sep 29, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025 •
edited
Loading

Test Results

    56 files  +    12      56 suites  +12   25m 7s ⏱️ + 3m 18s
 2 241 tests +    51   2 241 ✅ +    51  0 💤 ±0  0 ❌ ±0 
64 155 runs  +14 417  64 155 ✅ +14 417  0 💤 ±0  0 ❌ ±0 

Results for commit 15ccb5c. ± Comparison against base commit 9e1b558.

♻️ This comment has been updated with latest results.

csjall
csjall reviewed Sep 30, 2025
View reviewed changes
csjall
csjall reviewed Sep 30, 2025
View reviewed changes
csjall
csjall reviewed Sep 30, 2025
View reviewed changes
@mjohanse-emr mjohanse-emr requested a review from csjall September 30, 2025 18:14
@mjohanse-emr mjohanse-emr marked this pull request as ready for review September 30, 2025 18:14
bkeryan
bkeryan requested changes Sep 30, 2025
View reviewed changes
bkeryan
bkeryan reviewed Sep 30, 2025
View reviewed changes
bkeryan
bkeryan reviewed Sep 30, 2025
View reviewed changes
bkeryan
bkeryan reviewed Sep 30, 2025
View reviewed changes
bkeryan
bkeryan reviewed Sep 30, 2025
View reviewed changes
@mjohanse-emr mjohanse-emr requested a review from bkeryan October 2, 2025 21:38
@mjohanse-emr mjohanse-emr marked this pull request as draft October 2, 2025 21:39
@mjohanse-emr
Add a few more unit tests.
4266e9a 
Signed-off-by: Michael Johansen <[email protected]>
@mjohanse-emr
Fix doctests.
81d6ec1 
Signed-off-by: Michael Johansen <[email protected]>
@mjohanse-emr
Fix repr tests on oldest python/numpy.
221c233 
Signed-off-by: Michael Johansen <[email protected]>
@mjohanse-emr
Fix linting issue.
83d39c2 
Signed-off-by: Michael Johansen <[email protected]>
@mjohanse-emr
Include non-units properties in __repr__().
bb7d850 
Signed-off-by: Michael Johansen <[email protected]>
@mjohanse-emr
Fix linting issues.
96b1790 
Signed-off-by: Michael Johansen <[email protected]>
@mjohanse-emr mjohanse-emr marked this pull request as ready for review October 6, 2025 14:07
csjall
csjall approved these changes Oct 6, 2025
View reviewed changes
@bkeryan bkeryan mentioned this pull request Oct 8, 2025
Open
bkeryan
bkeryan requested changes Oct 8, 2025
View reviewed changes
@mjohanse-emr mjohanse-emr requested a review from bkeryan October 8, 2025 21:00
@mjohanse-emr mjohanse-emr merged commit a5f499d into main Oct 8, 2025
40 checks passed
@mjohanse-emr mjohanse-emr deleted the users/mjohanse/xy_data branch October 8, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csjall csjall csjall approved these changes

@bkeryan bkeryan bkeryan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjohanse-emr @csjall @bkeryan