Skip to content

worked on review comments

13f6d1f
Select commit
Loading
Failed to load commit list.
Open

NGINX Configs to Reference Remote External Files #1389

worked on review comments
13f6d1f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 15, 2026 in 1s

85.14% (target 80.00%)

View this Pull Request on Codecov

85.14% (target 80.00%)

Details

Codecov Report

❌ Patch coverage is 81.01695% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.14%. Comparing base (fab01ec) to head (13f6d1f).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
internal/file/external_file_operator.go 79.14% 20 Missing and 19 partials ⚠️
internal/file/file_manager_service.go 71.79% 9 Missing and 2 partials ⚠️
internal/file/file_plugin.go 0.00% 3 Missing ⚠️
internal/config/config.go 95.83% 1 Missing and 1 partial ⚠️
internal/file/file_service_operator.go 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
- Coverage   85.31%   85.14%   -0.18%     
==========================================
  Files         102      103       +1     
  Lines       12974    13261     +287     
==========================================
+ Hits        11069    11291     +222     
- Misses       1418     1461      +43     
- Partials      487      509      +22     
Files with missing lines Coverage Δ
internal/config/defaults.go 100.00% <ø> (ø)
internal/config/flags.go 100.00% <ø> (ø)
internal/config/types.go 87.65% <ø> (ø)
internal/model/config.go 90.47% <ø> (ø)
internal/file/file_service_operator.go 76.97% <94.44%> (+0.67%) ⬆️
internal/config/config.go 87.79% <95.83%> (+0.35%) ⬆️
internal/file/file_plugin.go 74.57% <0.00%> (-0.51%) ⬇️
internal/file/file_manager_service.go 74.06% <71.79%> (-0.75%) ⬇️
internal/file/external_file_operator.go 79.14% <79.14%> (ø)

... and 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab01ec...13f6d1f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.