Draft : NGINX Configs to Reference Remote External Files #1389

Akshay2191 · 2025-11-12T15:50:37Z

Extends the ConfigApply capability to manage NGINX configurations that reference external resources hosted at remote URLs. The agent now handles downloading of these files into the NGINX configuration directory before applying the new configuration.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING document
I have run make install-tools and have attached any dependency changes to this pull request
If applicable, I have added tests that prove my fix is effective or that my feature works
If applicable, I have checked that any relevant tests pass after adding my changes
If applicable, I have updated any relevant documentation (README.md)
If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

codecov · 2025-11-12T16:03:00Z

Codecov Report

❌ Patch coverage is 81.84932% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.09%. Comparing base (fab01ec) to head (52e6aa3).
⚠️ Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/file/external_file_operator.go	79.14%	20 Missing and 19 partials ⚠️
internal/file/file_manager_service.go	71.79%	9 Missing and 2 partials ⚠️
internal/config/config.go	95.83%	1 Missing and 1 partial ⚠️
internal/file/file_service_operator.go	94.44%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
- Coverage   85.31%   85.09%   -0.22%     
==========================================
  Files         102      103       +1     
  Lines       12974    13259     +285     
==========================================
+ Hits        11069    11283     +214     
- Misses       1418     1467      +49     
- Partials      487      509      +22

Files with missing lines	Coverage Δ
internal/config/defaults.go	`100.00% <ø> (ø)`
internal/config/flags.go	`100.00% <ø> (ø)`
internal/config/types.go	`87.65% <ø> (ø)`
internal/model/config.go	`90.47% <ø> (ø)`
internal/file/file_service_operator.go	`76.97% <94.44%> (+0.67%)`	⬆️
internal/config/config.go	`87.79% <95.83%> (+0.35%)`	⬆️
internal/file/file_manager_service.go	`74.06% <71.79%> (-0.75%)`	⬇️
internal/file/external_file_operator.go	`79.14% <79.14%> (ø)`

... and 25 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab01ec...52e6aa3. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

internal/config/config.go

internal/config/config_test.go

internal/file/file_manager_service.go

internal/file/file_manager_service_test.go

internal/config/config.go

internal/config/defaults.go

internal/file/file_service_operator.go

internal/file/file_manager_service.go

craigell · 2025-11-25T12:32:04Z

internal/file/file_service_operator_test.go

+		wantErrMsg string
+		wantErr    bool
+	}{
+		{


The following scenarios could increase coverage:

No destination specified

Restricted directory.

Two files to the same destination.

aphralG · 2025-11-26T11:25:00Z

internal/file/file_service_operator_test.go

+	}{
+		{
+			name: "Test 1: success",
+			prepare: func(t *testing.T) (string, string) {


Can this be changed to follow the way other tests are set up and formatted

internal/config/defaults.go

aphralG · 2025-11-26T11:29:04Z

internal/file/file_manager_service_test.go

+}
+
+//nolint:gocognit,revive,govet // cognitive complexity is 22
+func TestFileManagerService_downloadExternalFiles_Cases(t *testing.T) {


Can this test be simplified and changed to match the way other tests are set up and structured

aphralG · 2025-11-26T11:29:59Z

internal/file/file_manager_service_test.go

+	assert.Equal(t, fileName, dstArg, "RenameExternalFile destination argument mismatch")
+}
+
+func TestDownloadFileContent_MaxBytesLimit(t *testing.T) {


Can these tests please be combined

I tried to consolidate these divergent test scenarios (MaxBytes vs. Proxy Errors) but it spiked the cognitive complexity to 23 due the very different validation steps. Therefore I kept them seperate.

internal/file/file_manager_service_test.go

internal/file/file_manager_service.go

internal/config/config.go

# Conflicts: # internal/config/config.go # internal/config/types.go # internal/file/file_manager_service.go

# Conflicts: # internal/file/file_manager_service.go

# Conflicts: # internal/config/config.go # internal/config/types.go # internal/file/file_manager_service.go

github-actions · 2026-01-09T17:33:51Z

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:

I have hereby read the F5 CLA and agree to its terms

3 out of 4 committers have signed the CLA.
✅ (Akshay2191)[https://github.com/Akshay2191]
✅ (dhurley)[https://github.com/dhurley]
✅ (aphralG)[https://github.com/aphralG]
❌ @akshay Chawla
Akshay Chawla seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

Akshay2191 requested a review from a team as a code owner November 12, 2025 15:50

github-actions bot added the chore Pull requests for routine tasks label Nov 12, 2025

Akshay2191 self-assigned this Nov 19, 2025

aphralG reviewed Nov 20, 2025

View reviewed changes

dhurley reviewed Nov 21, 2025

View reviewed changes

Akshay2191 requested review from aphralG and dhurley November 24, 2025 16:22

craigell reviewed Nov 25, 2025

View reviewed changes

aphralG reviewed Nov 26, 2025

View reviewed changes

spencerugbo reviewed Dec 4, 2025

View reviewed changes

internal/file/file_manager_service.go Outdated Show resolved Hide resolved

internal/config/config.go Show resolved Hide resolved

dhurley approved these changes Dec 10, 2025

View reviewed changes

github-actions bot added dependencies documentation Improvements or additions to documentation labels Dec 18, 2025

Akshay2191 and others added 16 commits December 18, 2025 23:40

third party config support

e055610

# Conflicts: # internal/config/config.go # internal/config/types.go # internal/file/file_manager_service.go

lint fix

daf36e3

Added a generic file timeout

2b878a4

added generic timeout to create connection

c357355

added uT

d1e8a9d

Added UT

7e616fc

fix lint issues

1fd2cc6

Added UT for Proxy URL

ac5bd5e

increasing UT coverage

280ed4f

updated Mock management to test external file config apply

e494337

PR review comments addressed

28328a4

worked on PR comments

d77faea

worked on PR comments

7b59e69

removed duplicate rename function

2281b14

worked on review comment

3843ee2

Ensure only files are in file overview in config apply request (#1395)

480e402

# Conflicts: # internal/file/file_manager_service.go

aphralG and others added 7 commits December 19, 2025 00:01

Retry request if no response is sent by management plane (#1381)

0171367

third party config support

16839e8

# Conflicts: # internal/config/config.go # internal/config/types.go # internal/file/file_manager_service.go

Added a generic file timeout

433da00

removed duplicate rename function

cba25ca

linter fix

4837339

code fix for rebase

3225ff3

fixing rebase errors

2e981e0

Akshay2191 force-pushed the external-file-mgmt-integration branch from e50d100 to 2e981e0 Compare December 19, 2025 00:30

Akshay2191 added 2 commits January 6, 2026 15:21

refactored new code andded file validation

c28e679

fixed push error

e4cfe0c

Akshay2191 marked this pull request as draft January 6, 2026 15:26

Fixed UT test failing in git pipeline

5b8b5ab

Akshay2191 changed the title ~~NGINX Configs to Reference Remote External Files~~ Draft : NGINX Configs to Reference Remote External Files Jan 7, 2026

returning error message with code

52e6aa3

Draft : NGINX Configs to Reference Remote External Files #1389

Are you sure you want to change the base?

Draft : NGINX Configs to Reference Remote External Files #1389

Uh oh!

Conversation

Akshay2191 commented Nov 12, 2025

Checklist

Uh oh!

codecov bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

craigell Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

aphralG Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aphralG Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

aphralG Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Akshay2191 Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Nov 12, 2025 •

edited

Loading