PHP 8 curl Object Fixes #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsistla
reviewed
Dec 22, 2020
zsistla
reviewed
Dec 22, 2020
This was
linked to
issues
Dec 22, 2020
Closed
Fahmy-Mohammed
approved these changes
Dec 22, 2020
joshuabenuck
pushed a commit
to joshuabenuck/newrelic-php-agent
that referenced
this pull request
Feb 16, 2021
* Wrap curl fn wrapper arg parsing in PHP8-aware conditionals * Make check_curl_handle macro PHP8 compliant * Abstract curl_handle validity in function that accounts for pre and post PHP8 format
joshuabenuck
pushed a commit
that referenced
this pull request
Feb 16, 2021
* Wrap curl fn wrapper arg parsing in PHP8-aware conditionals * Make check_curl_handle macro PHP8 compliant * Abstract curl_handle validity in function that accounts for pre and post PHP8 format
joshuabenuck
pushed a commit
that referenced
this pull request
Apr 20, 2021
* Wrap curl fn wrapper arg parsing in PHP8-aware conditionals * Make check_curl_handle macro PHP8 compliant * Abstract curl_handle validity in function that accounts for pre and post PHP8 format
mfulb
pushed a commit
to mfulb/newrelic-php-agent
that referenced
this pull request
Sep 28, 2022
* Wrap curl fn wrapper arg parsing in PHP8-aware conditionals * Make check_curl_handle macro PHP8 compliant * Abstract curl_handle validity in function that accounts for pre and post PHP8 format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors all curl resource checks to account for the fact that in PHP 8, it is an object.
The necessary changes are nicely summarized here. As you can see, API compatibility was very well maintained by the upstream code in PHP, but also somewhat surprisingly, in C as well.
Unit tests (with valgrind) pass with no issues, and small manual curl test program is correctly instrumented.
Fixes #42
Fixes #51