Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 - Curl API changes #42

Closed
kneitinger opened this issue Nov 30, 2020 · 0 comments · Fixed by #70
Closed

PHP 8 - Curl API changes #42

kneitinger opened this issue Nov 30, 2020 · 0 comments · Fixed by #70
Assignees
@kneitinger
Labels
enhancement New feature or request
Milestone
PHP 8 Support

Comments

@kneitinger
Copy link
Contributor

Summary

The implementation of curl has changed somewhat in PHP 8. Previously, curl handles were resources, but as of PHP 8 are now class objects. For this ticket, correct our instrumentation to account for this change when PHP 8 is defined.

Desired Behavior

  • All occurrences of IS_RESOURCE are accounted for and fixed in our instrumentation
  • Since curl_close() no longer closes the curl handle (a task left to GC), verify with valgrind that our tests do handle this situation gracefully and appropriately.
  • Our Monolog Enricher's default Handler uses Curl to communicate with the NR API. Verify that this behavior still works as expected!
@kneitinger kneitinger added the enhancement New feature or request label Nov 30, 2020
@kneitinger kneitinger added this to the PHP 8 Support milestone Nov 30, 2020
@kneitinger kneitinger self-assigned this Dec 4, 2020
@kneitinger kneitinger linked a pull request Dec 22, 2020 that will close this issue
PHP 8 curl Object Fixes #70
Merged
@kneitinger kneitinger mentioned this issue Dec 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kneitinger kneitinger

Labels
enhancement New feature or request
Projects
None yet
Milestone
PHP 8 Support
Development

Successfully merging a pull request may close this issue.

PHP 8 curl Object Fixes
1 participant
@kneitinger