Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump line length to 120 #459

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Bump line length to 120 #459

merged 2 commits into from
Jan 7, 2025

Conversation

binaryseed
Copy link
Collaborator

Just because it's a little nicer

May need a rebase after all the other PRs I've opened :)

@binaryseed
Copy link
Collaborator Author

Will have to wait and rebase on top of #454

@tpitale
Copy link
Contributor

tpitale commented Dec 16, 2024

Looks good, let me know when you've rebased or merged master and I'll finish reviewing.

@tpitale
Copy link
Contributor

tpitale commented Dec 16, 2024

Looks like mix format for <= 1.14 is having some issue

Run mix format --check-formatted
** (Mix) mix format failed due to --check-formatted.
The following files are not formatted:

@binaryseed binaryseed force-pushed the vince/bump-line-length branch from 17d509a to 11fde5e Compare December 16, 2024 20:25
@binaryseed
Copy link
Collaborator Author

Updated, and went ahead and dropped 14 from the test matrix

@binaryseed binaryseed mentioned this pull request Dec 17, 2024
Merged
19 tasks
@tpitale tpitale merged commit c940d45 into master Jan 7, 2025
11 checks passed
@tpitale tpitale deleted the vince/bump-line-length branch January 7, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpitale tpitale tpitale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binaryseed @tpitale