Merge pull request #459 from newrelic/vince/bump-line-length

Bump line length to 120
newrelic · Jan 7, 2025 · c940d45 · c940d45
2 parents aa70bde + 11fde5e
commit c940d45
Show file tree

Hide file tree

Showing 14 changed files with 18 additions and 44 deletions.
diff --git a/.formatter.exs b/.formatter.exs
@@ -1,4 +1,5 @@
 [
+  line_length: 120,
   inputs: [
     "{lib,config,test}/**/*.{ex,exs}",
     "{mix,.formatter}.exs"

diff --git a/.github/workflows/elixir.yml b/.github/workflows/elixir.yml
@@ -25,8 +25,6 @@ jobs:
             otp: '26'
           - elixir: '1.15'
             otp: '26'
-          - elixir: '1.14'
-            otp: '25'
 
     steps:
     - name: Checkout

diff --git a/lib/new_relic/config.ex b/lib/new_relic/config.ex
@@ -256,8 +256,7 @@ defmodule NewRelic.Config do
   def event_harvest_config() do
     %{
       harvest_limits: %{
-        analytic_event_data:
-          Application.get_env(:new_relic_agent, :analytic_event_per_minute, 1000),
+        analytic_event_data: Application.get_env(:new_relic_agent, :analytic_event_per_minute, 1000),
         custom_event_data: Application.get_env(:new_relic_agent, :custom_event_per_minute, 1000),
         error_event_data: Application.get_env(:new_relic_agent, :error_event_per_minute, 100),
         span_event_data: Application.get_env(:new_relic_agent, :span_event_per_minute, 1000)

diff --git a/lib/new_relic/distributed_trace/w3c_trace_context/trace_parent.ex b/lib/new_relic/distributed_trace/w3c_trace_context/trace_parent.ex
@@ -19,11 +19,8 @@ defmodule NewRelic.DistributedTrace.W3CTraceContext.TraceParent do
   def decode(<<_::binary-size(@version), "-", "00000000000000000000000000000000", _::binary>>),
     do: invalid()
 
-  def decode(
-        <<_::binary-size(@version), "-", _::binary-size(@trace_id), "-", "0000000000000000",
-          _::binary>>
-      ),
-      do: invalid()
+  def decode(<<_::binary-size(@version), "-", _::binary-size(@trace_id), "-", "0000000000000000", _::binary>>),
+    do: invalid()
 
   def decode(
         <<version::binary-size(@version), "-", trace_id::binary-size(@trace_id), "-",

diff --git a/lib/new_relic/harvest/collector/supervisor.ex b/lib/new_relic/harvest/collector/supervisor.ex
@@ -26,8 +26,7 @@ defmodule NewRelic.Harvest.Collector.Supervisor do
 
   def data_supervisor(namespace, key) do
     Supervisor.child_spec(
-      {Harvest.DataSupervisor,
-       [namespace: namespace, key: key, lookup_module: Collector.AgentRun]},
+      {Harvest.DataSupervisor, [namespace: namespace, key: key, lookup_module: Collector.AgentRun]},
       id: make_ref()
     )
   end

diff --git a/lib/new_relic/harvest/telemetry_sdk/dimensional_metrics/harvester.ex b/lib/new_relic/harvest/telemetry_sdk/dimensional_metrics/harvester.ex
@@ -85,8 +85,7 @@ defmodule NewRelic.Harvest.TelemetrySdk.DimensionalMetrics.Harvester do
          %{type: type, name: name, value: new_value, attributes: attributes} = metric,
          metrics_acc
        ),
-       do:
-         Map.update(metrics_acc, {type, name, attributes}, metric, &update_metric(&1, new_value))
+       do: Map.update(metrics_acc, {type, name, attributes}, metric, &update_metric(&1, new_value))
 
   defp update_metric(
          %{type: :count, value: value} = current_metric,

diff --git a/lib/new_relic/harvest/telemetry_sdk/supervisor.ex b/lib/new_relic/harvest/telemetry_sdk/supervisor.ex
@@ -22,8 +22,7 @@ defmodule NewRelic.Harvest.TelemetrySdk.Supervisor do
 
   def data_supervisor(namespace, key) do
     Supervisor.child_spec(
-      {Harvest.DataSupervisor,
-       [namespace: namespace, key: key, lookup_module: TelemetrySdk.Config]},
+      {Harvest.DataSupervisor, [namespace: namespace, key: key, lookup_module: TelemetrySdk.Config]},
       id: make_ref()
     )
   end

diff --git a/lib/new_relic/instrumented/mix/task.ex b/lib/new_relic/instrumented/mix/task.ex
@@ -8,9 +8,7 @@ defmodule NewRelic.Instrumented.Mix.Task do
         _ ->
           require Logger
 
-          Logger.error(
-            "[New Relic] Unable to instrument #{inspect(__MODULE__)} since it isn't a Mix.Task"
-          )
+          Logger.error("[New Relic] Unable to instrument #{inspect(__MODULE__)} since it isn't a Mix.Task")
       end
     end
   end

diff --git a/lib/new_relic/sampler/beam.ex b/lib/new_relic/sampler/beam.ex
@@ -90,8 +90,7 @@ defmodule NewRelic.Sampler.Beam do
       input_kb: current.input_kb - previous.input_kb,
       output_kb: current.output_kb - previous.output_kb,
       reductions: current.reductions - previous.reductions,
-      scheduler_utilization:
-        delta(:util, previous.scheduler_utilization, current.scheduler_utilization)
+      scheduler_utilization: delta(:util, previous.scheduler_utilization, current.scheduler_utilization)
     }
   end
 

diff --git a/test/dimensional_metric_test.exs b/test/dimensional_metric_test.exs
@@ -2,9 +2,7 @@ defmodule DimensionalMetricTest do
   use ExUnit.Case
 
   test "reports dimensional metrics" do
-    TestHelper.restart_harvest_cycle(
-      NewRelic.Harvest.TelemetrySdk.DimensionalMetrics.HarvestCycle
-    )
+    TestHelper.restart_harvest_cycle(NewRelic.Harvest.TelemetrySdk.DimensionalMetrics.HarvestCycle)
 
     NewRelic.report_dimensional_metric(:count, "memory.foo_baz", 100, %{cpu: 1000})
     NewRelic.report_dimensional_metric(:summary, "memory.foo_bar", 50, %{cpu: 2000})
@@ -28,9 +26,7 @@ defmodule DimensionalMetricTest do
   end
 
   test "gauge dimensional metric is updated" do
-    TestHelper.restart_harvest_cycle(
-      NewRelic.Harvest.TelemetrySdk.DimensionalMetrics.HarvestCycle
-    )
+    TestHelper.restart_harvest_cycle(NewRelic.Harvest.TelemetrySdk.DimensionalMetrics.HarvestCycle)
 
     NewRelic.report_dimensional_metric(:gauge, "mem_percent.foo_baz", 10, %{cpu: 1000})
     NewRelic.report_dimensional_metric(:gauge, "mem_percent.foo_baz", 40, %{cpu: 1000})
@@ -51,9 +47,7 @@ defmodule DimensionalMetricTest do
   end
 
   test "count dimensional metric is updated" do
-    TestHelper.restart_harvest_cycle(
-      NewRelic.Harvest.TelemetrySdk.DimensionalMetrics.HarvestCycle
-    )
+    TestHelper.restart_harvest_cycle(NewRelic.Harvest.TelemetrySdk.DimensionalMetrics.HarvestCycle)
 
     NewRelic.report_dimensional_metric(:count, "OOM", 1, %{cpu: 1000})
     NewRelic.report_dimensional_metric(:count, "OOM", 1, %{cpu: 1000})
@@ -74,9 +68,7 @@ defmodule DimensionalMetricTest do
   end
 
   test "summary dimensional metric is updated" do
-    TestHelper.restart_harvest_cycle(
-      NewRelic.Harvest.TelemetrySdk.DimensionalMetrics.HarvestCycle
-    )
+    TestHelper.restart_harvest_cycle(NewRelic.Harvest.TelemetrySdk.DimensionalMetrics.HarvestCycle)
 
     NewRelic.report_dimensional_metric(:summary, "duration", 40.5, %{cpu: 1000})
     NewRelic.report_dimensional_metric(:summary, "duration", 20.5, %{cpu: 1000})

diff --git a/test/instrumented/task_test.exs b/test/instrumented/task_test.exs
@@ -157,9 +157,7 @@ defmodule InstrumentedTaskTest do
         Task.Supervisor.async_nolink(TestTaskSup, __MODULE__, :do_task, [:via_mfa])
         |> Task.await()
 
-        Task.Supervisor.async_nolink(TestTaskSup, __MODULE__, :do_task, [:via_mfa_opt],
-          shutdown: 1000
-        )
+        Task.Supervisor.async_nolink(TestTaskSup, __MODULE__, :do_task, [:via_mfa_opt], shutdown: 1000)
         |> Task.await()
       end)
       |> Task.await()

diff --git a/test/logs_in_context_test.exs b/test/logs_in_context_test.exs
@@ -63,9 +63,7 @@ defmodule LogsInContextTest do
   test "LogsInContext in :direct mode" do
     TestHelper.restart_harvest_cycle(TelemetrySdk.Logs.HarvestCycle)
 
-    TestHelper.restart_harvest_cycle(
-      NewRelic.Harvest.Collector.TransactionErrorEvent.HarvestCycle
-    )
+    TestHelper.restart_harvest_cycle(NewRelic.Harvest.Collector.TransactionErrorEvent.HarvestCycle)
 
     configure_logs_in_context(:direct)
 

diff --git a/test/metric_transaction_test.exs b/test/metric_transaction_test.exs
@@ -125,8 +125,7 @@ defmodule MetricTransactionTest do
 
     assert TestHelper.find_metric(
              metrics,
-             {"External/MetricTransactionTest.External.call",
-              "WebTransaction/Plug/GET//foo/:blah"}
+             {"External/MetricTransactionTest.External.call", "WebTransaction/Plug/GET//foo/:blah"}
            )
   end
 
@@ -146,8 +145,7 @@ defmodule MetricTransactionTest do
     # Scoped
     assert TestHelper.find_metric(
              metrics,
-             {"Function/MetricTransactionTest.External.make_queries/0",
-              "WebTransaction/Plug/GET//foo/:blah"}
+             {"Function/MetricTransactionTest.External.make_queries/0", "WebTransaction/Plug/GET//foo/:blah"}
            )
   end
 

diff --git a/test/other_transaction_test.exs b/test/other_transaction_test.exs
@@ -74,8 +74,7 @@ defmodule OtherTransactionTest do
 
     assert TestHelper.find_metric(
              metrics,
-             {"External/OtherTransactionTest.External.call",
-              "OtherTransaction/TransactionCategory/MyTaskName"}
+             {"External/OtherTransactionTest.External.call", "OtherTransaction/TransactionCategory/MyTaskName"}
            )
 
     span_events = TestHelper.gather_harvest(Collector.SpanEvent.Harvester)