feat: feePayer for Sudo fees #129
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2023
ratik
force-pushed
the
feat/NTRN-331-sudo-fees-payer
branch
from
f1d8419 to
147aae4
Compare
This was referenced Jan 23, 2023
pr0n00gler
requested changes
Jan 24, 2023
proto/interchaintxs/v1/tx.proto
Outdated
| // MsgSubmitTxResponse defines the response for Msg/SubmitTx | ||
| message MsgSubmitTxResponse { | ||
| // channel's sequence_id for outgoing ibc packet. Unique per a channel. | ||
| // channel's sequence_id for outgoing ibc packet. Unique per a channel.y |
| allowance, err := k.feegrantKeeper.GetAllowance(ctx, payerInfo.FeePayer, payerInfo.Sender) | ||
| if err != nil { | ||
| return err | ||
| } |
Collaborator
There was a problem hiding this comment.
new line after error handling, please
x/feerefunder/keeper/keeper.go
Outdated
| if payerInfo.FeePayer != nil && !payerInfo.FeePayer.Empty() { | ||
| allowance, err := k.feegrantKeeper.GetAllowance(ctx, payerInfo.FeePayer, payerInfo.Sender) | ||
| if err != nil { | ||
| return err |
Collaborator
There was a problem hiding this comment.
wrap error to make it more meaningful?
x/interchaintxs/keeper/msg_server.go
Outdated
Comment on lines
86
to
91
| feePayerAddr, err := sdk.AccAddressFromBech32(msg.Fee.Payer) | ||
| if msg.Fee.Payer != "" && err != nil { | ||
| k.Logger(ctx).Debug("SubmitTx: failed to parse fee payer address", "fee payer", msg.Fee.Payer) | ||
| return nil, sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "failed to parse address: %s", msg.Fee.Payer) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Just a suggestion: maybe we can define a method which accepts sender and payer and returns (feetypes.PayerInfo, error)?
Contributor
There was a problem hiding this comment.
+1, cause it looks a bit hard to read
NeverHappened
approved these changes
Jan 24, 2023
Contributor
NeverHappened
left a comment
NeverHappened
left a comment
There was a problem hiding this comment.
LGTM, mentioned small things
x/feerefunder/keeper/keeper.go
Outdated
| coins = append(coins, fee.RecvFee...) | ||
| _, err = allowance.Accept(ctx, coins, []sdk.Msg{}) | ||
| if err != nil { | ||
| return err |
…n-org/neutron into feat/NTRN-331-sudo-fees-payer
sotnikov-s
reviewed
Jan 25, 2023
x/feerefunder/keeper/keeper_test.go
Outdated
| FeePayer: nil, | ||
| }) | ||
|
|
||
| p, err = k.GetPayerInfo(ctx, TestAddress, TestAddress) |
Contributor
There was a problem hiding this comment.
To test logic to verify that it's different addresses it would probably be better to send different addresses as args
sotnikov-s
approved these changes
Jan 26, 2023
pr0n00gler
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related stuff: