feat: fee payer for sudo fee #70
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratik
force-pushed
the
feat/NTRN-331-payer-address-for-sudo-fees
branch
from
c08bc83 to
9865ef9
Compare
This was referenced Jan 23, 2023
src/testcases/ibc_transfer.test.ts
Outdated
| testState.wallets.neutron.demo1, | ||
| NEUTRON_DENOM, | ||
| ); | ||
| cm3 = new CosmosWrapper( |
Contributor
There was a problem hiding this comment.
cm3 before cm2 seems strange. Maybe it's time to rename these variables?
cm -> ntrnDemo1
cm3 -> ntrnDemo2
cm2 -> cosmosDemo2
Or please suggest something.
Because it's getting hard to read in test cases.
…n-org/neutron-integration-tests into feat/NTRN-331-payer-address-for-sudo-fees
sotnikov-s
reviewed
Jan 26, 2023
sotnikov-s
approved these changes
Jan 26, 2023
NeverHappened
approved these changes
Jan 27, 2023
Contributor
NeverHappened
left a comment
NeverHappened
left a comment
There was a problem hiding this comment.
LGTM, although we did not rename the cm1, cm2, cm3 in the interchaintx.test.ts, maybe we can do it in a separate task.
pr0n00gler
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related stuff:
please note: I've renamed simple test into ibc_transfer as it represents contents much better