Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency on neon-image in promote-images-dev #10437

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

jcgruenhage
Copy link
Member

@jcgruenhage jcgruenhage commented Jan 17, 2025

Problem

871e8b3 failed CI on main because a job ran to soon. This was caused by ea84ec3. While promote-images-dev does not inherently need neon-image, a few jobs depending on promote-images-dev do need it, and previously had it when it was promote-images, which depended on test-images, which in turn depended on neon-image.

Summary of changes

To ensure jobs depending docker.io/neondatabase/neon images get them, promote-images-dev gets the dependency to neon-image back which it previously had transitively through test-images.

@jcgruenhage jcgruenhage requested a review from a team as a code owner January 17, 2025 13:28
@jcgruenhage jcgruenhage enabled auto-merge January 17, 2025 13:30
@jcgruenhage jcgruenhage added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 053abff Jan 17, 2025
85 checks passed
@jcgruenhage jcgruenhage deleted the fix-promote-images-dev-neon-image-dep branch January 17, 2025 14:22
Copy link

7348 tests run: 6971 passed, 0 failed, 377 skipped (full report)


Flaky tests (5)

Postgres 17

Postgres 16

Code coverage* (full report)

  • functions: 33.7% (8437 of 25068 functions)
  • lines: 49.1% (70546 of 143613 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
71b8141 at 2025-01-17T14:28:31.236Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants