Skip to content

Commit

Permalink
Fix dependency on neon-image in promote-images-dev (#10437)
Browse files Browse the repository at this point in the history
## Problem
871e8b3 failed CI on main because a job
ran to soon. This was caused by
ea84ec3. While `promote-images-dev`
does not inherently need `neon-image`, a few jobs depending on
`promote-images-dev` do need it, and previously had it when it was
`promote-images`, which depended on `test-images`, which in turn
depended on `neon-image`.

## Summary of changes
To ensure jobs depending `docker.io/neondatabase/neon` images get them,
`promote-images-dev` gets the dependency to `neon-image` back which it
previously had transitively through `test-images`.
  • Loading branch information
jcgruenhage authored Jan 17, 2025
1 parent 871e8b3 commit 053abff
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,7 @@ jobs:
docker compose -f ./docker-compose/docker-compose.yml down
promote-images-dev:
needs: [ check-permissions, tag, vm-compute-node-image ]
needs: [ check-permissions, tag, vm-compute-node-image, neon-image ]
runs-on: ubuntu-22.04

permissions:
Expand Down

1 comment on commit 053abff

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7499 tests run: 7111 passed, 0 failed, 388 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 33.6% (8430 of 25068 functions)
  • lines: 49.1% (70547 of 143613 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
053abff at 2025-01-17T16:42:41.438Z :recycle:

Please sign in to comment.