-
Notifications
You must be signed in to change notification settings - Fork 4
feat(netwatch): adjust for quinn api changes #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/26/docs/net_tools/ Last updated: 2025-06-03T08:26:45Z |
netwatch/src/interfaces.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the whole confusion here.
It might be helpful to move this file to interfaces/native.rs
so it lives on the same level as wasm_browser.rs
.
The hope would be this makes it a lot clearer that they implement the same stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with moving on with this, even if I'm not super confident in the waker stuff.
It's fair to say it's roughly as good as the status quo.
A first step towards the work of #3276 ## Breaking changes - `iroh::watcher` is now its own crate `n0-watcher` - `iroh::endpoint::Endpoint::node_addr` now returns `impl Watcher<Value = Option<NodeAddr>>` - `iroh::endpoint::Endpoint::home_relay` now returns `impl Watcher<Value = Vec<RelayUrl>>` - `iroh::endpoint::Endpoint::bound_sockets` now returns `Vec<SocketAddr>` - `iroh-quinn` is updated to `0.14.0` Depends on - [x] n0-computer/n0-watcher#1 - [x] n0-computer/net-tools#26 - [x] n0-computer/quinn#67 - [x] n0-computer/n0-watcher#3 --------- Co-authored-by: Franz Heinzmann <[email protected]>
No description provided.