feat(netwatch): adjust for quinn api changes #26
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/26/docs/net_tools/ Last updated: 2025-05-27T08:52:18Z |
There was a problem hiding this comment.
Sorry for the whole confusion here.
It might be helpful to move this file to interfaces/native.rs so it lives on the same level as wasm_browser.rs.
The hope would be this makes it a lot clearer that they implement the same stuff.
| if this.fut.is_none() { | ||
| let socket = this.socket.clone(); | ||
| this.fut.set(Some(Box::pin(async move { | ||
| n0_future::future::poll_fn(|cx| socket.poll_writable(cx)).await |
There was a problem hiding this comment.
Looking at the implementation of poll_writable, it seems like this will use poll_send_ready, which I think isn't safe to use from multiple tasks concurrently?
I think this needs to call tokio's .writable() deep down instead.
There was a problem hiding this comment.
I's the same limitations as before/we have currently. Yes it looses wakers, but this can only be fully fixed if the udpsocket here stored the wakers, not by using the future internally, as on rebind we need to wake all of them, so relying on tokios internals is not enough
| pub fn send<'a, 'b>(&self, transmit: &'a quinn_udp::Transmit<'b>) -> SendFutQuinn<'a, 'b> { | ||
| SendFutQuinn { | ||
| socket: self.socket.clone(), | ||
| transmit, | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this used? I guess I don't know the downstream dependencies and which public functions are used.
All I know is quinn doesn't need this, but it might be used somewhere in net-report etc.
(making sure we don't accidentally leave fns we don't necessarily need)
There was a problem hiding this comment.
yes, iroh uses this
No description provided.