Skip to content

Make sure wakers are not overwritten for write readyness #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matheus23 opened this issue May 30, 2025 · 0 comments
Open

Make sure wakers are not overwritten for write readyness #28

matheus23 opened this issue May 30, 2025 · 0 comments

Comments

@matheus23
Copy link
Member

Context from this in a PR discussion: #26 (comment)

The way to fix this is to use .writable() and store the future to for polling, similar to how we do it in quinn.

However, in this case it's a little more complicated, since we've also got a lock around our socket, and might have to replace the socket when it errors out and needs to be rebound, so we should also store multiple wakers for each task that tried to send on a currently-being-replaced socket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant