feat: allow to encode a registry in openmetrics without EOF #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MetricsSource::encode_openmetrics
adds the# EOF\n
marker at the end of the encoded openmetrics output. This is the expected last characters in the openmetrics text format. Currently,MetricsSource::encode_openmetrics
is the only public API to encode airoh_metrics::Registry
into the openmetrics text format.When combining output from different sources, users should be able to add the EOF marker themselves. This PR adds a public function
Registry::encode_openmetrics_to_writer
that encodes without the EOF.For 1.0 we should revisit the MetricsSource trait, but the change in this PR is semver compatible so can be in a patch release, so that downstream users of
[email protected]
can make use of it.Breaking Changes
Notes & open questions
Change checklist