fix: rename new method to not conflict with trait method

Author: Frando

src/registry.rs

@@ -85,13 +85,13 @@ impl Registry {
     ///
     /// Note that this does not add the EOF marker to the output. Use [`encode_openmetrics_eof`]
     /// to do that.
-    pub fn encode_openmetrics(&self, writer: &mut impl Write) -> fmt::Result {
+    pub fn encode_openmetrics_to_writer(&self, writer: &mut impl Write) -> fmt::Result {
         for group in &self.metrics {
             group.encode_openmetrics(writer, self.prefix.as_deref(), &self.labels)?;
         }
 
         for sub in self.sub_registries.iter() {
-            sub.encode_openmetrics(writer)?;
+            sub.encode_openmetrics_to_writer(writer)?;
         }
         Ok(())
     }
@@ -119,7 +119,7 @@ pub trait MetricsSource: Send + 'static {
 
 impl MetricsSource for Registry {
     fn encode_openmetrics(&self, writer: &mut impl std::fmt::Write) -> Result<(), Error> {
-        self.encode_openmetrics(writer)?;
+        self.encode_openmetrics_to_writer(writer)?;
         write_eof(writer)?;
         Ok(())
     }

src/service.rs

@@ -2,6 +2,7 @@
 
 use std::{
     net::SocketAddr,
+    ops::Deref,
     sync::{Arc, RwLock},
     time::{Duration, Instant},
 };
@@ -23,13 +24,13 @@ pub type RwLockRegistry = Arc<RwLock<Registry>>;
 impl MetricsSource for RwLockRegistry {
     fn encode_openmetrics(&self, writer: &mut impl std::fmt::Write) -> Result<(), Error> {
         let inner = self.read().expect("poisoned");
-        <Registry as MetricsSource>::encode_openmetrics(&inner, writer)
+        inner.encode_openmetrics(writer)
     }
 }
 
 impl MetricsSource for Arc<Registry> {
     fn encode_openmetrics(&self, writer: &mut impl std::fmt::Write) -> Result<(), Error> {
-        <Registry as MetricsSource>::encode_openmetrics(self, writer)
+        Arc::deref(self).encode_openmetrics(writer)
     }
 }
 

src/static_core.rs

@@ -49,7 +49,7 @@ pub struct GlobalRegistry;
 impl MetricsSource for GlobalRegistry {
     fn encode_openmetrics(&self, writer: &mut impl std::fmt::Write) -> Result<(), Error> {
         let core = crate::static_core::Core::get().ok_or(NoMetricsSnafu.build())?;
-        <Registry as MetricsSource>::encode_openmetrics(&core.registry, writer)
+        core.registry.encode_openmetrics(writer)
     }
 }