Show mailing list at registration option #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cellule
force-pushed
the
mike_ml_user_register
branch
from
daf419d to
1dd93de
Compare
| return { | ||
| value: mailingList[field], | ||
| requestChange: _.bind(this.requestChange, this, mailingList, field) | ||
| requestChange: _.bind(this.requestChange, this, mailingList, field, parseFunc) |
There was a problem hiding this comment.
Any reason why you use lodash's bind rather than the native one? Either way, React already autobinds all instance methods, you can provide null instead of this.
|
CR done. |
|
Good to merge! |
mathieumg
added a commit
that referenced
this pull request
Dec 1, 2014
Show mailing list at registration option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to check if a mailing should appear in the registration form for new user. Since the registration is owned by module.user, the use of this will be done in another PR