Mailing List register contribution #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2014
mathieumg
force-pushed
the
mike_register_contribution
branch
from
c6960f3 to
76f8728
Compare
| id: userId | ||
| } | ||
| }, function(err) { | ||
| callback(err && "Error registering user to mailing lists"); |
There was a problem hiding this comment.
the signature of the callback is (errorMessage: string;)
https://github.com/my-koop/module.user/tree/mike_register_contribution#methods
it doesn't need to be an actual Error object
There was a problem hiding this comment.
But it should be localized though
|
CR done. |
|
Good to merge. |
Cellule
added a commit
that referenced
this pull request
Dec 1, 2014
Mailing List register contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a component to contribute to the register form using mailing list only available at register.
Depends on #5