This repository was archived by the owner on Oct 4, 2021. It is now read-only.
Use Mono for monodoc.dll on Windows #4700
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 1, 2018 10:30
We've told people to use "MonoLiraries.msi" for years to satisfy MonoDevelop build dependencies on Windows. This is antique - grabbed from Mono 2.6, signed with an expired Novell Authenticode cert. Much better to use monodoc.dll from a Mono installation than from MonoLibraries.msi
slluis
suggested changes
May 2, 2018
|
@slluis do you have a better solution than "install these Novell-signed pieces of Mono 2.6 into the .NET GAC"? That's the current dependency. Hell, this shouldn't actually change that - HintPath isn't mandatory, msbuild will still resolve a GAC copy from MonoLibraries.msi as a fallback |
|
See also #4434 |
Therzok
suggested changes
May 3, 2018
| @@ -137,7 +137,10 @@ | |||
| <Reference Include="System.Xml" /> | |||
| <Reference Include="System.Configuration" /> | |||
| <Reference Include="System.Core" /> | |||
| <Reference Include="monodoc, Version=1.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756" /> | |||
| <Reference Include="monodoc, Version=1.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756"> | |||
| <HintPath Condition="'$(OS)' == 'Windows_NT'">$(MSBuildProgramFiles32)\Mono\lib\mono\monodoc\monodoc.dll</HintPath> | |||
There was a problem hiding this comment.
That means we depend on mono on Windows to build monodevelop. 👎 from me. We should have a nuget
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've told people to use "MonoLiraries.msi" for years to satisfy MonoDevelop build dependencies on Windows. This is antique - grabbed from Mono 2.6, signed with an expired Novell Authenticode cert. Much better to use monodoc.dll from a Mono installation than from MonoLibraries.msi
This patch adds a conditional HintPath to the Mono install directory
Tested as fixing builds on Windows, and not breaking on Linux.