-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(screenshot): some unwanted texts wrapping (@byseif21) #7339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,6 +108,7 @@ | |
| justify-content: flex-end; | ||
| gap: 0 1em; | ||
| flex-wrap: wrap; | ||
| white-space: nowrap; | ||
|
|
||
| .fas { | ||
| margin-left: 0.33em; | ||
|
|
@@ -761,6 +762,13 @@ | |
| margin-bottom: 0.25rem; | ||
| display: flex; | ||
| align-items: center; | ||
|
|
||
| // for "input history" wrapping in screenshot for small screens | ||
| flex-wrap: wrap; | ||
|
|
||
| > span { | ||
| white-space: nowrap; | ||
| } | ||
| } | ||
| .words { | ||
| display: flex; | ||
|
|
@@ -800,7 +808,7 @@ | |
| } | ||
| &.withLigatures { | ||
| .word { | ||
| overflow-wrap: anywhere; | ||
| //overflow-wrap: anywhere; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. breaks words at arbitrary letters,
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if the word gets longer than the words wrapper width?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok i see in custom it's not limited hmm |
||
| padding-bottom: 2px; // compensate for letter border | ||
|
|
||
| .hints { | ||
|
|
@@ -1005,6 +1013,7 @@ | |
| font-size: 1rem; | ||
| line-height: 1rem; | ||
| margin-bottom: 0.25rem; | ||
| white-space: nowrap; | ||
| } | ||
|
|
||
| .bottom { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this to fix a prod bug where in small screen
bottomclass breaks outwrapperclass cuz oftitleand makes the words history goes out "visual overflow" so we let it wrap and span "input history" word not to fix our ss bug