-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(screenshot): some unwanted texts wrapping (@byseif21) #7339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| &.withLigatures { | ||
| .word { | ||
| overflow-wrap: anywhere; | ||
| //overflow-wrap: anywhere; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaks words at arbitrary letters,
I don’t see a valid use for internal word breaking here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the word gets longer than the words wrapper width?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i see in custom it's not limited hmm
|
|
||
| // for "input history" wrapping in screenshot for small screens | ||
| flex-wrap: wrap; | ||
|
|
||
| > span { | ||
| white-space: nowrap; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this to fix a prod bug where in small screen bottom class breaks out wrapper class cuz of title and makes the words history goes out "visual overflow" so we let it wrap and span "input history" word not to fix our ss bug
white-space: nowrap;that happens for word history in custom & zen where ligatures are always on.
for "type mode" word (
topclass ingroup testType) & "input history" word (resultWordsHistory'stitleclass)