DRIVERS-2295 Convert CSFLE spec tests to unified test format #1784
Conversation
Co-authored-by: Kevin Albertson <[email protected]>
| @@ -27,8 +27,6 @@ jobs: | |||
| - name: Regenerate JSON test files | |||
| run: | | |||
| python3 ./source/server-discovery-and-monitoring/tests/errors/generate-error-tests.py | |||
| python3 ./source/client-side-encryption/etc/generate-corpus.py ./source/client-side-encryption/corpus | |||
There was a problem hiding this comment.
Add back generate-corpus.py. I expect the corpus tests are still relevant.
There was a problem hiding this comment.
Were changes needed to the unified test runner to drop the enxcol_.<coll>.esc and enxcol_.<coll>.ecoc? If so, update the unified test format spec to note.
| @@ -0,0 +1,113 @@ | |||
| description: client bulkWrite with queryable encryption | |||
There was a problem hiding this comment.
Suggest adding the client bulkWrite test in a separate PR labeled with the ticket: DRIVERS-2888. I expect supporting client bulkWrite requires driver changes that can be done separate from migrating legacy tests.
There was a problem hiding this comment.
Some drivers now use a git submodule to sync spec tests (example: PHP). As a result, when they update the submodule, all tests get synced. I request restoring the .json/.yml files (not templates) for the legacy tests. Once all drivers have synced the new tests, the old tests can be removed.
That may prevent a loss of test coverage (e.g. driver upgrades submodule to get non-CSFLE test updates, but does not-yet have the test runner changes implemented to run the new CSFLE tests)
There was a problem hiding this comment.
This seems like a big flaw in the git submodule approach.
No description provided.