-
Notifications
You must be signed in to change notification settings - Fork 244
DRIVERS-3106 revise fle2v2-BypassQueryAnalysis #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Suggest adding rationale and linking to a C driver PR for others to reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe poc-queryable-encryption.yml
also requires updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments. Suggest running git merge master
to get recent fixes to GitHub actions: #1797
source/unified-test-format/tests/valid-pass/poc-queryable-encryption.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Albertson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#1756 accidentally used outcome matching in
fle2v2-BypassQueryAnalysis
which is not supported by the spec. This PR replaces it with a find on an unencrypted client.Edit: also revise
poc-queryable-encryption
C driver PR: mongodb/mongo-c-driver#2004