Skip to content

PYTHON-5342 Fix test_dns_failures test #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 8, 2025
Merged

PYTHON-5342 Fix test_dns_failures test #2336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a090b32
Revert "PYTHON-5342 - Skip async test_srv_polling tests on Windows (#…
blink1073 May 7, 2025
2e7914c
windows-ctypes
blink1073 May 7, 2025
7c777bc
fix requirements
blink1073 May 7, 2025
7e17df6
fix metadata
blink1073 May 7, 2025
06b9347
fix the test
blink1073 May 7, 2025
f7ca050
debug
blink1073 May 7, 2025
c93f0e3
debug
blink1073 May 7, 2025
5cb200d
reorder
blink1073 May 7, 2025
19eebab
add a delay
blink1073 May 7, 2025
9cc74c7
try a longer delay
blink1073 May 7, 2025
3c5695f
try without exc
blink1073 May 8, 2025
d2d827c
remove callback call
blink1073 May 8, 2025
e8834fb
try empty list
blink1073 May 8, 2025
b929fd5
avoid cross-talk
blink1073 May 8, 2025
94dae39
fix close
blink1073 May 8, 2025
c3ea465
try with source repo
blink1073 May 8, 2025
ef37568
undo dnspython changes
blink1073 May 8, 2025
eccc85a
undo ordering
blink1073 May 8, 2025
859b116
undo extra change
blink1073 May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/asynchronous/test_srv_polling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import time
from test.utils_shared import FunctionCallRecorder
from typing import Any
from unittest import skipIf

sys.path[0:0] = [""]

Expand Down Expand Up @@ -92,7 +91,6 @@ def __exit__(self, exc_type, exc_val, exc_tb):
self.disable()


@skipIf(not _IS_SYNC and sys.platform == "win32", "PYTHON-5342 known issue on Windows")
class TestSrvPolling(AsyncPyMongoTestCase):
BASE_SRV_RESPONSE = [
("localhost.test.build.10gen.cc", 27017),
Expand Down Expand Up @@ -186,6 +184,9 @@ def dns_resolver_response():
):
await assertion_method(expected_response, client)

# Close the client early to avoid affecting the next scenario run.
await client.close()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does leaving the client open have side effects?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed in office hours: the thought is that the patching was affecting the previous client(s) that were not yet garbage collected.


async def test_addition(self):
response = self.BASE_SRV_RESPONSE[:]
response.append(("localhost.test.build.10gen.cc", 27019))
Expand Down
5 changes: 3 additions & 2 deletions test/test_srv_polling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import time
from test.utils_shared import FunctionCallRecorder
from typing import Any
from unittest import skipIf

sys.path[0:0] = [""]

Expand Down Expand Up @@ -92,7 +91,6 @@ def __exit__(self, exc_type, exc_val, exc_tb):
self.disable()


@skipIf(not _IS_SYNC and sys.platform == "win32", "PYTHON-5342 known issue on Windows")
class TestSrvPolling(PyMongoTestCase):
BASE_SRV_RESPONSE = [
("localhost.test.build.10gen.cc", 27017),
Expand Down Expand Up @@ -186,6 +184,9 @@ def dns_resolver_response():
):
assertion_method(expected_response, client)

# Close the client early to avoid affecting the next scenario run.
client.close()

def test_addition(self):
response = self.BASE_SRV_RESPONSE[:]
response.append(("localhost.test.build.10gen.cc", 27019))
Expand Down
Loading