PYTHON-5342 Fix test_dns_failures test #2336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ongodb#2320)" This reverts commit e7db0e3.
NoahStapp
approved these changes
May 8, 2025
ShaneHarvey
reviewed
May 8, 2025
| @@ -186,6 +184,9 @@ def dns_resolver_response(): | |||
| ): | |||
| await assertion_method(expected_response, client) | |||
|
|
|||
| # Close the client early to avoid affecting the next scenario run. | |||
| await client.close() | |||
There was a problem hiding this comment.
Why does leaving the client open have side effects?
There was a problem hiding this comment.
We discussed in office hours: the thought is that the patching was affecting the previous client(s) that were not yet garbage collected.
ShaneHarvey
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.